-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a minor visual issue in the reader post cards #9525
Fix a minor visual issue in the reader post cards #9525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting and fixing this!
We only need to add android:paddingStart="@dimen/margin_medium"
to the visit
LinearLayout
view. The rest of the changes can be reverted. We want to keep the asymmetrical marginEnd
and marginStart
on the image_visit_icon
ImageView
. The start padding and asymmetrical margins will allow the icon to line up vertically with the starting edge of the text above it while giving a little space between the icon and the "Visit" text. See the screenshots below for illustration.
Also, I don't think this change needs an entry in the release notes. |
Looks good @maxme ! While we're here, do you think we could also align the site name + date to the 72dp keyline? |
9ff2b5b
to
95ce264
Compare
Ok got it, updated in c645635 |
@SylvesterWilmott: Updated the site name / date alignment - also updated site header ("Discover") alignment: |
Thank you for this one! Looks so much cleaner now. |
Thanks @maxme , looks great! |
To test: Open the reader, make sure the "visit" icon is vertically aligned with the other elements.
Update release notes: this is a very minor fix, should I update the release notes?