Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a minor visual issue in the reader post cards #9525

Conversation

maxme
Copy link
Contributor

@maxme maxme commented Apr 6, 2019

To test: Open the reader, make sure the "visit" icon is vertically aligned with the other elements.

LTR1
RTL1

Update release notes: this is a very minor fix, should I update the release notes?

@theck13 theck13 self-requested a review April 6, 2019 15:53
@theck13 theck13 self-assigned this Apr 6, 2019
@theck13 theck13 added [Status] Needs Code Review [Status] Needs Design Review A designer needs to sign off on the implemented design. Design Needed A design solution is needed. Reader labels Apr 6, 2019
@theck13 theck13 added this to the 12.2 milestone Apr 6, 2019
Copy link
Contributor

@theck13 theck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this!

We only need to add android:paddingStart="@dimen/margin_medium" to the visit LinearLayout view. The rest of the changes can be reverted. We want to keep the asymmetrical marginEnd and marginStart on the image_visit_icon ImageView. The start padding and asymmetrical margins will allow the icon to line up vertically with the starting edge of the text above it while giving a little space between the icon and the "Visit" text. See the screenshots below for illustration.

reader_button_visit_ltr

reader_button_visit_rtl

@theck13
Copy link
Contributor

theck13 commented Apr 7, 2019

Update release notes: this is a very minor fix, should I update the release notes?

Also, I don't think this change needs an entry in the release notes.

@SylvesterWilmott
Copy link

Looks good @maxme !

While we're here, do you think we could also align the site name + date to the 72dp keyline?

@maxme maxme force-pushed the issue/fix-minor-margin-issue-with-reader-visit-button branch from 9ff2b5b to 95ce264 Compare April 8, 2019 13:22
@maxme
Copy link
Contributor Author

maxme commented Apr 8, 2019

Thanks for spotting and fixing this!

We only need to add android:paddingStart="@dimen/margin_medium" to the visit LinearLayout view. The rest of the changes can be reverted. We want to keep the asymmetrical marginEnd and marginStart on the image_visit_icon ImageView. The start padding and asymmetrical margins will allow the icon to line up vertically with the starting edge of the text above it while giving a little space between the icon and the "Visit" text. See the screenshots below for illustration.

Ok got it, updated in c645635

@maxme
Copy link
Contributor Author

maxme commented Apr 8, 2019

While we're here, do you think we could also align the site name + date to the 72dp keyline?

@SylvesterWilmott: Updated the site name / date alignment - also updated site header ("Discover") alignment:

site-name-72dp

@theck13 theck13 self-requested a review April 8, 2019 14:52
@theck13 theck13 merged commit a898057 into wordpress-mobile:develop Apr 8, 2019
@theck13 theck13 removed [Status] Needs Code Review [Status] Needs Design Review A designer needs to sign off on the implemented design. labels Apr 8, 2019
@mattmiklic
Copy link
Member

Thank you for this one! Looks so much cleaner now.

@maxme maxme deleted the issue/fix-minor-margin-issue-with-reader-visit-button branch April 8, 2019 16:05
@SylvesterWilmott
Copy link

Thanks @maxme , looks great!

@mattmiklic mattmiklic removed the Design Needed A design solution is needed. label Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants