Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shared image information once it's been inserted in the Post #9427

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Mar 16, 2019

Fixes #9408

This PR removes Intent.EXTRA_STREAM extra from the intent once it's been processed, to avoid re-inserting same media on each Activity re-creation.

Similar to what we did back in 277b69a in PR #6786

To test:

  1. open the Photos app
  2. pick an image
  3. share to WP
  4. select a site on the WP app and choose "create new post"
  5. once the editor opens and the image starts uploading, rotate the device
  6. verify it's still one image being uploaded, and no duplicates appear.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

…void re-inserting same media on each Activity re-creation
@mzorz
Copy link
Contributor Author

mzorz commented Mar 18, 2019

cc @jtreanor for the cut to beta

@daniloercoli
Copy link
Contributor

I've found a case where the shared picture is re-added multiple times.

To test:
0. Enable don't keep activities

  1. open the Photos app
  2. pick an image
  3. share to WP
  4. select a site on the WP app and choose "create new post"
  5. once the editor opens and the image starts uploading (you can even let it uploading and finish) Tap the home button
  6. Wait a bit and tap on the WP icon
  7. Boom, the editor is reload and the picture added again.

@mzorz
Copy link
Contributor Author

mzorz commented Mar 18, 2019

Nice find there @daniloercoli ! Made a small adjustment in 6bceb03 to not allow this 👍

Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mzorz mzorz merged commit 788e78f into release/12.0 Mar 18, 2019
@mzorz mzorz deleted the issue/9408-share-rotate-device-duplicate-media branch March 18, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants