Issue/drawables with tint (Part 5)

[theck13]

Fix

Update drawable usages with tint so that resources can be consolidated and minimized. Since the minSdkVersion is now 21, we can use the android:tint="color" attribute and ImageView.setImageTintList(ColorStateList) method for all drawables. That allows us combine all drawables with the same path into a single file, which removes redundant files and reduces the app footprint. Using tint also helps us with theming and app-wide color changes in the future.

I chose to make white (#ffffff) the default color for drawables since white is the absence of pigment and that correlates to the absence of tint. It makes differentiating tinted and non-tinted icons easier also.

Note

This is the fifth installment of the Drawables with Tint series (Part 1, Part 2, Part 3, Part 4).

Test

Shortcuts

0. Use device running Nougat (Android 7.1, API 25) or later.
1. Go to app launcher.
2. Long-press WordPress app.
3. Notice icons are shown next to Stats, Notifications, and New post labels.

Activity Log

0. Select site with ability to rewind activity.
1. Go to Sites tab.
2. Tap Activity item.
3. Tap event able to rewind.
4. Notice History icon shown next to Rewind label.

Blog Post

0. Select site with at least one image in a blog post.
1. Go to Sites tab.
2. Tap Blog Posts under Publish section.
3. Tap blog post with at least one image.
4. Tap image in blog post.
5. Notice Remove from post icon is shown in top app bar.

Media

0. Select site with audio in media library.
1. Go to Sites tab.
2. Tap Media under Publish section.
3. Tap Audio tab.
4. Tap media grid item.
5. Notice white/black play icon in collapsible toolbar background.
6. Tap play icon in collapsible toolbar background.
7. Notice black/white play icon in collapsible toolbar background.

People

1. Go to Sites tab.
2. Tap People under Configuration section.
3. Tap Invite action in top app bar.
4. Notice Info icon is shown next to Role label.

Site Settings

0. Select site with Personal, Premium, or Business plan.
1. Go to Sites tabs.
2. Tap Settings under Configuration section.
3. Tap Start Over under Advanced section.
4. Notice History icon is shown next to Let Us Help label in Start Over screen.

Reader

0. Use device with slow network connection.
1. Go to Reader tab.
2. Notice placeholder with Globe icon is shown for site avatars.
3. Notice placeholder with User icon is shown for user avatars.

Jetpack Remote Install

0. Log in with only self-hosted site without Jetpack.
1. Go to Sites tab.
2. Tap Stats item.
3. Tap Install Jetpack button.
4. Go through Jetpack remote install steps.
5. Notice Jetpack icon shown throughout installation.

Review

Only one developer is required to review these changes, but anyone can perform the review.

[khaykov]

I compared this branch against develop side by side and everything looks good 👍