Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Gutenberg for all and hide legacy editors options #9208

Merged
merged 13 commits into from
Feb 12, 2019
Merged

Enable Gutenberg for all and hide legacy editors options #9208

merged 13 commits into from
Feb 12, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Feb 11, 2019 •
edited
Loading

**
** WARNING: Don't merge before the 11.8 app freeze has happened (currently scheduled for Monday Feb 11th 2019)
**

Addresses:

Before testing

  1. Before using this PR, set the editor to "Visual" in the App settings. This will be useful for testing that Aztec sill be forced where appropriate and the Visual (or the Legacy editor for that matter) won't be used at all.

To test A:

  1. In the App Settings, have the Use block editor for new posts to OFF
  2. Open a new or empty post. Verify that the editor opened is Aztec. Away to verify that is to look for the "H" format bar icon. If there then it's Aztec.
  3. Go back to the posts list and open a non-empty post that doesn't contain blocks.
  4. Verify that it's Aztec again that gets used
  5. Go back to the posts list and open a non-empty post made with Gutenberg before
    6 Verify that the editor used is now Gutenberg. Look for the "undo/redo" buttons in the bottom toolbar, characteristic of Gutenberg at this point.

To test B:

  1. In the App Settings, have the Use block editor for new posts to ON
  2. Open a new or empty post. Verify that the editor opened is Gutenberg. Look for the "undo/redo" buttons in the bottom toolbar, characteristic of Gutenberg at this point.
  3. Go back to the posts list and open a non-empty post that doesn't contain blocks.
  4. Verify that it's Aztec again that gets used
  5. Go back to the posts list and open a non-empty post made with Gutenberg before
    6 Verify that the editor used is now Gutenberg. Look for the "undo/redo" buttons in the bottom toolbar, characteristic of Gutenberg at this point.

To test C:

  • Try to build any app flavor (vanilla, zalpha, wasabi) and verify that Gutenberg is available and working.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@hypest
Aztec and GB support editing while uploading so, always true
0fa3dfe
@hypest
Gutenberg for block posts, conditionally for new posts
db88356
@hypest
No need for warning, no-block posts open in Aztec
68c2e9f
@hypest
Introduce "use Gutenberg" for new posts App Setting
630f454 
And hardcode the `is...Enabled` App settings to only have Aztec and
Gutenberg enabled. This way, the code that depends on those flags can
still run fine while we're transitioning away from supporting the 2
oldest editors.
@hypest hypest requested a review from daniloercoli February 11, 2019 13:08
@hypest hypest mentioned this pull request Feb 11, 2019
Merged
1 task
@hypest hypest added this to the 11.9 milestone Feb 11, 2019
@jtreanor
Copy link
Contributor

WARNING: Don't merge before the 11.8 app freeze has happened (currently scheduled for Monday Feb 11th 2019)

You're safe, the freeze is done 😄

@hypest hypest self-assigned this Feb 11, 2019
@hypest
Copy link
Contributor Author

hypest commented Feb 11, 2019

Added the "Not ready for review" flag to postpone until I have another closer look at the PostListFragment change.

@hypest
Revert "Aztec and GB support editing while uploading so, always true"
5de5f6c 
This reverts commit 0fa3dfe.

Reverting to let the code be untouched for now. Besides, hardcoded the
AppPrefs.isAztecEditorEnabled() method to true anyway.
@hypest
Add missing import
b5007ef
@hypest
Removed unused resources reported by linter
4efe7fe
@hypest
Copy link
Contributor Author

hypest commented Feb 11, 2019

Lifted the "Not ready for review" flag, ready for a pass!

@hypest hypest changed the title Feature/hide legacy editors options Enable Gutenberg for all and hide legacy editors options Feb 11, 2019
@daniloercoli
Copy link
Contributor

daniloercoli commented Feb 11, 2019 •
edited
Loading

LGTM! Let me know if you want the other PR reviewed before, or merge and change the base branch to the other!

Added: I've already reviewed the other PR.

@hypest
Merge pull request #9210 from wordpress-mobile/feature/tag-gb-flag-fo…
4647aa7 
…r-support

Tag for the Gutenberg default flag for Support
@hypest hypest merged commit 8812a1e into develop Feb 12, 2019
@hypest hypest deleted the feature/hide-legacy-editors-options branch February 12, 2019 09:21
@hypest hypest mentioned this pull request Feb 12, 2019
Closed
This was referenced Feb 12, 2019
Closed
Closed
@koke koke mentioned this pull request Feb 14, 2019
Closed
2 tasks
@mzorz mzorz mentioned this pull request Nov 19, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

Assignees

@hypest hypest

Labels
None yet
Projects
None yet
Milestone
11.9 ❄️
Development

Successfully merging this pull request may close these issues.
3 participants
@hypest @jtreanor @daniloercoli