Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design changes to the most popular block #9161

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Design changes to the most popular block #9161

merged 1 commit into from
Feb 1, 2019

Conversation

planarvoid
Copy link
Contributor

Fixes #9069
This PR introduces design changes to the Most popular block. This includes:

  • Changing title to "Most Popular Time"
  • Removing of the list header
  • Adding a calendar icon to the post popular day and time icon to the most popular time
  • Adding a "of views" to the items value

screenshot_1548930468

To test:

  • Go to Stats/Insights
  • Scroll to the Most Popular Time block
  • Check that the updated designs are correct

@planarvoid planarvoid added this to the 11.8 milestone Jan 31, 2019
@planarvoid planarvoid self-assigned this Jan 31, 2019
@SylvesterWilmott
Copy link

Looks great @planarvoid thanks!

@0nko 0nko self-assigned this Jan 31, 2019
0nko
0nko approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 👍

@0nko 0nko merged commit 67cd989 into develop Feb 1, 2019
@0nko 0nko deleted the feature/update_design_of_most_popular branch February 1, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0nko 0nko 0nko approved these changes

@SylvesterWilmott SylvesterWilmott Awaiting requested review from SylvesterWilmott

Assignees

@planarvoid planarvoid

@0nko 0nko

Labels
Stats
Projects
None yet
Milestone
11.8
Development

Successfully merging this pull request may close these issues.
4 participants
@planarvoid @SylvesterWilmott @0nko @irfano