-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gb/feature upload media file #9120
Conversation
# Conflicts: # libs/gutenberg-mobile
WPAndroid support for media/image upload from Gutenberg
…o JS on reattachment
# Conflicts: # libs/gutenberg-mobile
…on successful upload
Passing converted Int mediaId
# Conflicts: # libs/gutenberg-mobile
# Conflicts: # libs/gutenberg-mobile
*Upload captured photo
Generated by 🚫 Danger |
Added the |
…gment as it was already moved to PostUtils before
…ound_process Gutenberg - async media upload Post background processing
As per chat with @marecar3 I've been testing this quite a bit to make sure all of the features we introduced in separate PRs feeding this one were still working correctly. Apparently uploads work well, reattachment works well, capture photo works well, but choosing an item from media library doesn't do anything. Issues found while testing:
Let's fix these two then we can merge this. Also left to do on other set of PRs:
|
PR addressing it here #9150 |
PRs addressing this other point here: |
Avoid multiple selection of pics/video when Gutenberg enabled
#9151) Passing mediaId in appendMediaFile gluecode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM!
Description :
This PR introduces image file upload from Gutenberg which implementation is based on this issue.
This is the first and base iteration of a task that should be implemented. Initial idea is to present an image picker from gutenberg editor which will trigger the upload process when the user picks an image.
Following PR's :
gutenberg-mobile
gutenberg
Update release notes:
RELEASE-NOTES.txt
.