Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move insights up and down in the list #9047

Merged

Conversation

planarvoid
Copy link
Contributor

@planarvoid planarvoid commented Jan 22, 2019

Fixes #8953
This is related to the FluxC PR - wordpress-mobile/WordPress-FluxC-Android#1088

This PR adds an overflow menu to each Title on the Insights tab. This menu contains button to move the item up, down or remove it from the list.

To test:

  • Open Stats
  • You see only Latest post summary, Today stats and Most popular block in Stats
  • You see an button in each title
  • Clicking the button opens a Popup menu
  • The popup menu contains 3 items - Move up, Move down and Remove
    • The first item doesn't contain the Move up action
    • The last item doesn't contain the Move down action
  • Clicking the actions moves the block up/down/removes it from the list
  • Adding blocks is not yet implemented so be careful with testing it

@planarvoid planarvoid added this to the 11.8 milestone Jan 22, 2019
@planarvoid planarvoid self-assigned this Jan 22, 2019
@planarvoid planarvoid requested a review from 0nko January 23, 2019 07:55
@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 Danger

@0nko 0nko self-assigned this Jan 24, 2019
@planarvoid planarvoid removed the request for review from 0nko February 7, 2019 17:09
@planarvoid planarvoid modified the milestones: 11.8, 11.9 Feb 8, 2019
@jtreanor jtreanor modified the milestones: 11.9 ❄️, 12.0 Mar 4, 2019
@0nko 0nko modified the milestones: 12.0 ❄️, 12.1 Mar 20, 2019
@0nko 0nko self-requested a review March 20, 2019 18:07
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool :). I've found a couple of quirks:

  • When you tap on the overflow menu of a card and dismiss it, it's not possible to tap it again. You have to first tap a different card's menu button and then it works again.
  • When you move the Latest Post Summary down and use PTR, the screen is automatically scrolled down to that card for some reason.

@planarvoid
Copy link
Contributor Author

@0nko thanks for the check 👍 , I think I've fixed both the issues (at least I cannot reproduce them anymore)

@0nko 0nko self-requested a review March 22, 2019 11:42
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, the issues are fixed and the menu works great! Thanks! 💯

@0nko 0nko merged commit c57e673 into feature/manage_insights_readonly Mar 22, 2019
@0nko 0nko deleted the feature/move_insights_up_and_down branch March 22, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants