-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move insights up and down in the list #9047
Move insights up and down in the list #9047
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty cool :). I've found a couple of quirks:
- When you tap on the overflow menu of a card and dismiss it, it's not possible to tap it again. You have to first tap a different card's menu button and then it works again.
- When you move the Latest Post Summary down and use PTR, the screen is automatically scrolled down to that card for some reason.
...a/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/CommentsUseCase.kt
Outdated
Show resolved
Hide resolved
…ights_up_and_down
@0nko thanks for the check 👍 , I think I've fixed both the issues (at least I cannot reproduce them anymore) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, the issues are fixed and the menu works great! Thanks! 💯
Fixes #8953
This is related to the FluxC PR - wordpress-mobile/WordPress-FluxC-Android#1088
This PR adds an overflow menu to each Title on the Insights tab. This menu contains button to move the item up, down or remove it from the list.
To test:
Move up
,Move down
andRemove
Move up
actionMove down
action