Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use React Native's version of okhttp3 to fix self signed SSL #9040

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Don't use React Native's version of okhttp3 to fix self signed SSL #9040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions libs/editor/WordPressEditor/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,15 @@ dependencies {
api ('com.github.wordpress-mobile.WordPress-Aztec-Android:wordpress-comments:v1.3.14')

if (rootProject.ext.buildGutenbergFromSource) {
implementation project(':react-native-gutenberg-bridge')
implementation (project(':react-native-gutenberg-bridge')) {
exclude group: 'com.squareup.okhttp3'
}
} else {
implementation (waitJitpack('com.github.wordpress-mobile', 'gutenberg-mobile', submoduleGitHash('../../../', 'libs/gutenberg-mobile')))
implementation (waitJitpack('com.github.wordpress-mobile', 'gutenberg-mobile', submoduleGitHash('../../../', 'libs/gutenberg-mobile'))) {
// Inheriting RN's okhttp version can interfere with FluxC SSL handling
// See https://github.com/wordpress-mobile/WordPress-Android/issues/9032 and https://github.com/wordpress-mobile/WordPress-FluxC-Android/issues/919
exclude group: 'com.squareup.okhttp3'
}
}

// Required Aztec dependencies (they should be included but Jitpack seems to be stripping these out)
Expand Down