Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional tracking for remote install #8321

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Add additional tracking for remote install #8321

merged 1 commit into from
Sep 17, 2018

Conversation

planarvoid
Copy link
Contributor

This PR is adding tracking of Jetpack remote install cancellation and adds some additional tracking of the JRI result.

To test:

  • login with a self-hosted site
  • click on stats
  • go back
  • Cancel event is being tracked
  • reopen stats
  • finish the flow
  • Complete event is being tracked

@planarvoid planarvoid added this to the 10.9 ❄️ milestone Sep 17, 2018
@0nko 0nko self-assigned this Sep 17, 2018
@0nko 0nko self-requested a review September 17, 2018 16:19
0nko
0nko approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works! 🚢

@0nko 0nko merged commit 886601a into release/10.9 Sep 17, 2018
@0nko 0nko deleted the fix/add_missing_tracking_of_cancelling_jetpack_install branch September 17, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0nko 0nko 0nko approved these changes

Assignees

@0nko 0nko

Labels
Jetpack
Projects
None yet
Milestone
10.9
Development

Successfully merging this pull request may close these issues.
2 participants
@planarvoid @0nko