Private & Pending Pages #8316
Merged
Private & Pending Pages #8316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- necessary because a list type may contain multiple page status types
0nko
added
the
[Status] Needs Design Review
|
Looks great! |
SylvesterWilmott
removed
the
[Status] Needs Design Review
planarvoid
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8313. This PR adds support for pages with
PrivateandPending reviewstatus. The new design includes support for 2 tags under the page title.To test:
PrivateorPending reviewstatusNote: I've discovered a bug when
PrivateorPending reviewstatus isn't saved when the Back button is pressed instead of Update in the editor. This is unrelated and will be fixed in a different PR.Also, I've temporarily disabled the PPP unit tests because they keep failing in Travis even though they are correct. This is already being addressed by #8303.