Add wordpress.com prefix after encoding the URL #8292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8289
This check
redirectUrl.startsWith(JETPACK_PATH)
never passed because we were comparing the string/jetpack
with the string before encoding (which never contains/
). The bug was caused by a check that is checking the URL inWPWebViewActivity
. The url was relative - it didn't contain thehttp://wordpress.com
prefix.To test:
jurassic.ninja
Sign-up with Google
when asked to login to wp.com