Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wordpress.com prefix after encoding the URL #8292

Merged

Conversation

planarvoid
Copy link
Contributor

Fixes #8289

This check redirectUrl.startsWith(JETPACK_PATH) never passed because we were comparing the string /jetpack with the string before encoding (which never contains /). The bug was caused by a check that is checking the URL in WPWebViewActivity. The url was relative - it didn't contain the http://wordpress.com prefix.

To test:

  • Create a site with jurassic.ninja
  • Add an admin account with a google email (not connected to another wp.com account)
  • Login with your self-hosted site
  • Setup Jetpack
  • Select Sign-up with Google when asked to login to wp.com
  • Approve connection
  • Finish the flow without crashes

@planarvoid planarvoid added this to the 10.9 milestone Sep 10, 2018
@theck13 theck13 self-requested a review September 10, 2018 15:54
Copy link
Contributor

@theck13 theck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@theck13 theck13 merged commit 909cdf3 into develop Sep 10, 2018
@theck13 theck13 deleted the issue/8289_add_wordpress_com_prefix_in_jetpack_web_client branch September 10, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants