Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/missing fab string #8246

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Issue/missing fab string #8246

merged 1 commit into from
Aug 28, 2018

Conversation

theck13
Copy link
Contributor

@theck13 theck13 commented Aug 28, 2018

Fix

Add missing fab_add_tag_desc string to default strings.xml resource file, which was removed in b5287f4#diff-96c14faed2c61eacb909ae0349b44cef.

@theck13
Add missing string to default resource file for site settings tag lis…
6b68694 
…t floating action button content description
@theck13 theck13 added this to the 10.7 ❄️ milestone Aug 28, 2018
@theck13 theck13 requested a review from loremattei August 28, 2018 12:47
loremattei
loremattei approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
:shipit: :-)

@loremattei loremattei merged commit a813693 into release/10.7 Aug 28, 2018
@loremattei loremattei deleted the issue/missing-fab-string branch August 28, 2018 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loremattei loremattei loremattei approved these changes

Assignees
No one assigned
Labels
Tag/Category Management
Projects
None yet
Milestone
10.7
Development

Successfully merging this pull request may close these issues.
2 participants
@theck13 @loremattei