Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: localized filters (ReaderTag) #8095

Merged
merged 4 commits into from
Jul 23, 2018

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Jul 23, 2018

Fixes #8069

This PR does a few things:

  • first, it adds a locale param when fetching Reader Tags from the server /read/menu endpoint so the titles can be properly localized (68c2526)
  • second, it forces a server call update when the user changes the app's language and makes sure to retrieve things in the right locale (d0bd21e)
  • finally, given we take a default string for "Saved posts" from the app resources and append it to the Tag filter list in the database ReaderTagTable table, we're now also taking the Tag's title into account when comparing lists, to account for potential locale changes. (a5d6245)

BEFORE

readertagbefore

AFTER

readertag

To test:

  1. go to the Reader's tab and check the filters are all in the configured language.
  2. go to the Me tab, then App Settings, then change your locale to something else
  3. go back to the Reader's tab and check the filters are all in the newly configured language.

@mzorz mzorz added this to the 10.6 milestone Jul 23, 2018
@mzorz mzorz requested review from AmandaRiu and theck13 and removed request for AmandaRiu July 23, 2018 13:44
Copy link
Contributor

@theck13 theck13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@theck13 theck13 merged commit 4742dd6 into develop Jul 23, 2018
@theck13 theck13 deleted the issue/8069-reader-filters-localized branch July 23, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants