Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forgotten WpNetworkImageView in xmls #8093

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Fix forgotten WpNetworkImageView in xmls #8093

merged 1 commit into from
Jul 23, 2018

Conversation

malinajirka
Copy link
Contributor

I forgot to change some xml tags while migrating from Volley to Glide.

To test:
Please make sure the xml layouts are only used with ImageLoader and are not used with WPNetworkImage view.

@malinajirka malinajirka requested a review from khaykov July 23, 2018 12:18
@malinajirka malinajirka added this to the 10.6 milestone Jul 23, 2018
@khaykov khaykov self-assigned this Jul 23, 2018
khaykov
khaykov approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I confirmed that all three are used with ImageManger.

@khaykov khaykov merged commit 70e7681 into develop Jul 23, 2018
@malinajirka malinajirka deleted the feature/glide-forgotten-wpnetworkimage-views branch February 20, 2019 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaykov khaykov khaykov approved these changes

Assignees

@khaykov khaykov

Labels
None yet
Projects
None yet
Milestone
10.6
Development

Successfully merging this pull request may close these issues.
2 participants
@malinajirka @khaykov