Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/7996 actionable empty states (Part 1) #8055

Merged
merged 11 commits into from
Jul 19, 2018

Conversation

theck13
Copy link
Contributor

@theck13 theck13 commented Jul 18, 2018

Fix

Add the actionable empty state view class, ActionableEmptyView, and implement a single instance of the actionable empty states described in #7996. Only one instance is included in this pull request to show the new class in action and keep the changeset small. The remaining actionable empty states in #7996 will be included in a subsequent pull request. See the screenshots below for illustration.

aes_media

Test

  1. Go to My Site tab.
  2. Tap Media item under Publish section.
  3. Tap All, Images, Documents, Videos, and Audio tabs.
  4. Notice empty view when no media is present.
  5. Tap Upload Media button.
  6. Notice new media popup menu.

@theck13 theck13 added General [Status] Needs Design Review A designer needs to sign off on the implemented design. labels Jul 18, 2018
@theck13 theck13 added this to the 10.6 milestone Jul 18, 2018
Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@SylvesterWilmott
Copy link

Looking good!

Does the text area have a maximum width? Also what does it look like with a long text string there (3 lines)?

@theck13
Copy link
Contributor Author

theck13 commented Jul 18, 2018

Does the text area have a maximum width?

The title and subtitle (not shown in the screenshots above) have a maximum width of 300dp and a horizontal margin of 30dp.

Also what does it look like with a long text string there (3 lines)?

Here's what the title looks like with a long text string of three lines.

aes_media_lines

@theck13
Copy link
Contributor Author

theck13 commented Jul 18, 2018

After chatting with @SylvesterWilmott, we decided to remove the maximum height of the image and update the maximum width of the text to 440dp. See the screenshots below for illustration.

aes_media_update_phone

aes_media_update_tablet

@SylvesterWilmott
Copy link

Looks great @theck13 !

@SylvesterWilmott SylvesterWilmott removed the [Status] Needs Design Review A designer needs to sign off on the implemented design. label Jul 19, 2018
@0nko 0nko self-assigned this Jul 19, 2018
@0nko
Copy link
Contributor

0nko commented Jul 19, 2018

:shipit:

@0nko 0nko merged commit e01d22b into develop Jul 19, 2018
@0nko 0nko deleted the issue/7996-actionable-empty-states branch July 19, 2018 11:38
@theck13 theck13 restored the issue/7996-actionable-empty-states branch July 19, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants