-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/7996 actionable empty states (Part 1) #8055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Looking good! Does the text area have a maximum width? Also what does it look like with a long text string there (3 lines)? |
The title and subtitle (not shown in the screenshots above) have a maximum width of
Here's what the title looks like with a long text string of three lines. |
After chatting with @SylvesterWilmott, we decided to remove the maximum height of the image and update the maximum width of the text to |
Looks great @theck13 ! |
Fix
Add the actionable empty state view class,
ActionableEmptyView
, and implement a single instance of the actionable empty states described in #7996. Only one instance is included in this pull request to show the new class in action and keep the changeset small. The remaining actionable empty states in #7996 will be included in a subsequent pull request. See the screenshots below for illustration.Test