Added snackbar when coming from Zendesk notfication #8043
Conversation
There was a problem hiding this comment.
Code looks good! 
I kind of want to figure out the deep linking issue though, this still feels weird, albeit better than the current solution. Thanks for the PR @mzorz, I'll wait for the design review and feedback for the merge!
|
Totally agreed we should aim at having deep linking; this is only a patch to all extent 👍 |
| @@ -292,6 +294,11 @@ private void handleOpenPageIntent(Intent intent) { | |||
| break; | |||
| case ARG_ME: | |||
| mBottomNav.setCurrentPosition(PAGE_ME); | |||
| if (intent.getBooleanExtra(WPMainActivity.ARG_SHOW_ZENDESK_HINT_SNACKBAR, false)) { | |||
| Snackbar.make(findViewById(R.id.coordinator), | |||
| R.string.support_push_notification_message_hint_snackbar, Snackbar.LENGTH_LONG).show(); | |||
There was a problem hiding this comment.
Can I suggest to use a timeout of 2 x Snackbar.LENGTH_LONG ?
Since there is no way to bring it back when it's gone, and the users can still don't know where to go to open the tickets. (feel free to ignore this if the current timeout on real usage is long enough).
|
Is there a way to bring the user to the "Help & Support" View instead of "Me" then we can guide them using the orange dot on the tickets row? |
|
Hi @SylvesterWilmott |
|
Sounds good to me @mzorz |
|
Merging this one into |
@SylvesterWilmott We couldn't add the dot, because Zendesk doesn't provide that functionality and iOS relies on push notifications which is not very reliable, at least not on Android. If we were to implement it, it's likely that we'd show the dot in some cases where there is no new ticket and we won't show the dot when there is one. I think that's more confusing than not having the dot at all. |
While testing notifications for WPAndroid 10.4 we identified a (what seemed to us broken) flow when tapping a Zendesk notification that only brings you to the
Mescreen in WPAndroid, leaving it up to the user to figure out that they have to tap onHelp & Supportand thenMy Tickets, then finally select the conversation to be able to take it up from there.From conversations with @oguzkocer and @aerych it looks like there were many hurdles with this integration, and this was actually a expected behavior as explained in #7839 and was so described in the tests steps in #7955
This PR adds a snackbar that explains the user a bit more as to what they need to do in order to complete the desired action (to look into an HE answer to a question they initiated through
Help & Support -> Contact Ussection of the app).BEFORE:
AFTER:
(see even on a screen not so small, the
Help & Supportsection of the app is not even shown, so it's even harder to decide what to do next weren't it for the snackbar).To test:
Metab, then tapHelp & Supportand finallyContact us.backtwice).Metab and a snackbar appears, explaining what to do next in order to complete the desired action.cc-ing @SylvesterWilmott by recommendation from @aerych: even if there's not much space of action here, I'd love to hear your feedback - feel free to please recommend a better message if needed, and we can also make the length to which the Snackbar stays on screen to a specific amount of time (for example, 5 seconds).
Maybe not as urgently, if I may request, do you think there might be better way to explain / close the gap in this flow while we still don't have proper deep-linking (i.e. a way to make a tap on the notification directly open the conversation within context)?. Thanks in advance.
cc @oguzkocer for code review
cc @loremattei so we keep an eye on it before full rollout of 10.4