Replace Volley with Glide in Stats #8025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@malinajirka Can you ping me when this is ready for review? Thanks! |
|
@malinajirka I think the stats refresh project is coming at some point, so probably this part will be remade from scratch with some other design, but in meantime, I think that the current state (without icon) looks better. We either show Icons at every row or don't show them at all :) |
|
@oguzkocer It's ready for the first pass!;) Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7961
Replaces Volley with Glide in the Stats.
Images which were using
WPNetworkImageView.ImageType.GONE_UNTIL_AVAILABLE, were never visible due to a bug in the WPNetworkImageView. What I'm unsure about is whether it looks good when only some sites have an icon. Wdyt @nozomimimi - should I fix the bug and start showing them or keep them hidden?First column is current state
Second column is after the bug fix
To test:
Modified sections:
tags and categories, publicize, referrers, comments, followers, authors, clicks
countries (modified only on Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP)