Retry failed posts from post list #6789
Conversation
mzorz
changed the base branch from
mzorz/media-success-notifications-write-post
to
issue/6389-upload-service-notification
|
If you run this on a device with a smaller screen, the retry button wraps to the second set of buttons (so it doesn't show up until you tap "More"). Should it be in the first set instead?
(This screenshot was taken from a Nexus 4 emulator running API 23) |
| default: | ||
| return 0; | ||
| } | ||
| } | ||
|
|
||
| public static int getTextColorResId(int buttonType) { |
There was a problem hiding this comment.
Minor tip: I've started using the @StringRes, @DrawableRes and @ColorRes annotations for these type of routines. ie: public static @ColorRes int getTextColorResId(int buttonType)
There was a problem hiding this comment.
Niiice! Added annotations in dd2caaf
| @@ -1225,8 +1225,8 @@ | |||
| <string name="error_media_load">Unable to load media</string> | |||
| <string name="error_media_save">Unable to save media</string> | |||
| <string name="error_media_canceled">Uploading media were canceled</string> | |||
| <string name="error_media_recover_post">We were unable to upload this post\'s media. Please edit the post to try again.</string> | |||
| <string name="error_media_recover_page">We were unable to upload this page\'s media. Please edit the page to try again.</string> | |||
| <string name="error_media_recover_post">We were unable to upload this post\'s media. Please tap retry or edit the post to try again.</string> | |||
There was a problem hiding this comment.
This is really wordy, plus it uses the pronoun "we" which Google recommends avoiding. The user should be able to figure out they can edit or retry without us telling them, so how about simply, "Unable to upload this post's media?"
There was a problem hiding this comment.
I'm amazed about how you are so much into details. Thanks! Made the change as suggested in 8cba571
I did this change in 74fc93a, but could you double check please? not sure if it's going to work correctly with the conditionals there are for showing |
There are quite a few problems here, such as the Publish button disappearing after you hit
|
This reverts commit 74fc93a.
|
|
Fixes #6407
Unhides and implements the
Retrybutton in Posts List, by making use of the implementation ofUploadService.To test:
RETRYbutton becomes visible on that Post item, along with the snackbar and corresponding notification.cc @nbradbury