Async media: adding publishing Snackbars to MySiteFragment #6425
Conversation
…PostListFragment and MySiteFragment
aforcier
added
the
[Status] Needs Design Review
|
Looks great! 👍 |
| } | ||
|
|
||
| public static void showSnackbar(Activity activity, int messageRes, int buttonTitleRes, View.OnClickListener onClickListener) { | ||
| Snackbar.make(activity.findViewById(R.id.coordinator), messageRes, Snackbar.LENGTH_LONG) |
There was a problem hiding this comment.
UploadUtils knowing about the coordinator layout ID seems weird - how about we pass in the View to the static methods as well?
There was a problem hiding this comment.
(This also applies to the second showSnackbar() method below.)
|
|
||
| public static void showSnackbar(Activity activity, String text) { | ||
| Snackbar.make(activity.findViewById(R.id.coordinator), | ||
| text, Snackbar.LENGTH_LONG).show(); |
There was a problem hiding this comment.
Since we're doing this, let's make this one consistent and use the Snackbar.make() method that accepts a resource ID instead of a String (like the showSnackbar() above this one is using).
| } | ||
| } | ||
|
|
||
| public static void showSnackbar(Activity activity, int messageRes, int buttonTitleRes, View.OnClickListener onClickListener) { |
There was a problem hiding this comment.
These two showSnackbar() methods can be private, I think it makes to hide them.
There was a problem hiding this comment.
This line and several others exceed 120 chars.
…d added some CR to keep 120 chars width down
|
ready for another round @aforcier 🙇 |
| public void onPostUploaded(PostStore.OnPostUploaded event) { | ||
| final PostModel post = event.post; | ||
| SiteModel site = getSelectedSite(); | ||
| if (isAdded() && event.post != null && event.post.getLocalSiteId() == site.getId()) { |
There was a problem hiding this comment.
getSelectedSite() is @Nullable, so we need to null check before calling site.getId() in this case.
There was a problem hiding this comment.
oops good catch - did that check and also moved isAdded() check a bit up here 28a9d58
…s added, then checked for site != null to avoid NPE
aforcier
removed
the
[Status] Needs Design Review
|
Looks good @mzorz! |
Extends the functionality implemented in #6233 to the Main screen (My sites) where the floating edit button also appears.
To test: follow the instructions in all cases in #6233
cc @aforcier