Possible fix to TransactionTooLarge crash #5698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
we'll see if that fixes the issue in 7.2.
|
@maxme i have been facing the same crash and wanted to know if the commit fixed this issue for you guys ? |
|
@gaurav-mishra8 unfortunately that hasn't been the case - it's still there and we haven't found a consistent fix for it, other than palliatives or workarounds |
There is a known issue that must be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5456. I have been unable to reproduce this crash no matter how many pages of notifications/reader posts I have browsed. I have tested on both emulator and my Pixel, the state seems to be saved without any issues. Since the report doesn't contain much info, this is just a possible fix. I was inclined to do the same for
ReaderPostPagerActivityin case the issue is happening there, but this might be better to identify the issue. As @maxme mentioned, the issue started afterNotificationDetailFragmentAdapter, so that should be the first place we test.To test:
/cc @maxme