Feature/425 free memory cache when the device running on low-memory #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -596,6 +597,11 @@ public void onTrimMemory(final int level) { | |||
| } else { | |||
| background = false; | |||
There was a problem hiding this comment.
Won't this cause background to be set to false when the level is TRIM_MEMORY_BACKGROUND, TRIM_MEMORY_MODERATE or TRIM_MEMORY_COMPLETE?
There was a problem hiding this comment.
Yes, we want background = true only when 'level == ComponentCallbacks2.TRIM_MEMORY_UI_HIDDEN'-
nbradbury
added a commit
that referenced
this pull request
Dec 11, 2013
…-cache Feature/425 free memory cache when the device running on low-memory
maxme
added a commit
that referenced
this pull request
Jun 29, 2016
260a0d5 Merge pull request #428 from wordpress-mobile/issue/204-start-post-formatted-text fb29391 Merge pull request #430 from wordpress-mobile/issue/429-html-regex-crash 438932b Fix #429 HTML mode styling crash 445938d Merge pull request #427 from wordpress-mobile/issue/417-format-current-word d38b4ab Merge branch 'develop' into issue/204-start-post-formatted-text 709b82f Merge branch 'develop' into issue/417-format-current-word 4758e2a Fix #204 by persisting inline styles when typing in an empty post 4b86c90 Merge pull request #426 from wordpress-mobile/sync-wpandroid e4b4565 When applying inline formatting, apply the style to the entire word adjacent to the cursor cb9f57c Bumped targetSdkVersion to 24 13043cb Bumped support library versions to 24 60fb931 Updated Travis config for Android 24 72ae111 Merge commit '7cee07f51ba62c3415d15fb71b0d83c7f507f843' into sync-editor 9faeee7 Merge pull request #425 from wordpress-mobile/fix-example-image 7a44419 Remove unused strings from the editor and merge them with the main strings.xml file for i18n 5031c47 Fixed issue where partial text selections would be expanded to the full word when linking 314e706 Extracted cursor expansion part of getSelectedTextToLinkify into a separate method 9005ef3 Merge branch 'release/5.5' into develop fc4c730 Fix broken image link in example post 61b592c Merge commit 'd0d8dd46c2b8223d66ec3e80578788d1b6cd8b85' into release/5.5 e7289ce Adjusted spacing and styling for text expansion JS methods e6a29b5 Merge branch 'develop' into issue/3924-method-count a008e48 Merge branch 'release/5.5' into develop a7395aa Merge commit '49ac39827552c17c8d5b65eca236a55961cf6814' into release/5.5 0c7e9f1 Merge commit '1cf141b3362c5c44f27a8b65775d3db27ac5756a' into release/5.5 5123e3c Merge branch 'release/5.5' into develop b15d049 Merge commit '65eec31755233d054ff01bf729eea6d233f6d7df' into release/5.5 9e8fc97 Merge commit '2fc5d53d4ba45ed45c806a5ac0772458a4ef403e' into release/5.5 aab8458 update compileSdkVersion and buildToolsVersion in every subtrees 3c57356 update gradle wrapper to 2.14 3d748d5 onFeaturedImageChanged signature changed: long instead of int a3a53d3 Merge branch 'hotfix/5.4.2' into release/5.5 19170dc Use a long for featured image IDs git-subtree-dir: libs/editor git-subtree-split: 260a0d5ba0eae70b44d4ccc826d2a2025f344280
aforcier
added a commit
that referenced
this pull request
Jul 11, 2016
eb069ba 1.3 version bump 0130742 Merge pull request #436 from wordpress-mobile/issue/383-drop-editor-common c017777 Moved JS tests out of editor assets folder, to test/js 7072c80 Moved example JS folder to example app assets 012ef21 Deleted unused ios-editor.html e7ae18d Moved 'read-only' JS libraries to libs/ folder 4fc87bf Updated README bb0f8ec Deleted libs/editor-common, moving its assets into the main project's assets folder (and deleting the symlink that was previously used) 7dcc1a9 Merge pull request #435 from wordpress-mobile/issue/432-evaluateJavaScript-not-supported 3b5fd66 Added debug logging when reverting to compatibility EditorWebView for custom ROMs be1722d Set WebView LayoutParams when reverting to compatibility WebView for custom ROM fix a6d3101 Check for custom ROMs using a 4.3 WebView in a 4.4 Android build, and revert to compatibility WebView for those devices 260a0d5 Merge pull request #428 from wordpress-mobile/issue/204-start-post-formatted-text fb29391 Merge pull request #430 from wordpress-mobile/issue/429-html-regex-crash 438932b Fix #429 HTML mode styling crash 445938d Merge pull request #427 from wordpress-mobile/issue/417-format-current-word d38b4ab Merge branch 'develop' into issue/204-start-post-formatted-text 709b82f Merge branch 'develop' into issue/417-format-current-word 4758e2a Fix #204 by persisting inline styles when typing in an empty post 4b86c90 Merge pull request #426 from wordpress-mobile/sync-wpandroid e4b4565 When applying inline formatting, apply the style to the entire word adjacent to the cursor cb9f57c Bumped targetSdkVersion to 24 13043cb Bumped support library versions to 24 60fb931 Updated Travis config for Android 24 72ae111 Merge commit '7cee07f51ba62c3415d15fb71b0d83c7f507f843' into sync-editor 9faeee7 Merge pull request #425 from wordpress-mobile/fix-example-image 7a44419 Remove unused strings from the editor and merge them with the main strings.xml file for i18n 5031c47 Fixed issue where partial text selections would be expanded to the full word when linking 314e706 Extracted cursor expansion part of getSelectedTextToLinkify into a separate method 9005ef3 Merge branch 'release/5.5' into develop fc4c730 Fix broken image link in example post 61b592c Merge commit 'd0d8dd46c2b8223d66ec3e80578788d1b6cd8b85' into release/5.5 e7289ce Adjusted spacing and styling for text expansion JS methods e6a29b5 Merge branch 'develop' into issue/3924-method-count a008e48 Merge branch 'release/5.5' into develop a7395aa Merge commit '49ac39827552c17c8d5b65eca236a55961cf6814' into release/5.5 0c7e9f1 Merge commit '1cf141b3362c5c44f27a8b65775d3db27ac5756a' into release/5.5 5123e3c Merge branch 'release/5.5' into develop b15d049 Merge commit '65eec31755233d054ff01bf729eea6d233f6d7df' into release/5.5 9e8fc97 Merge commit '2fc5d53d4ba45ed45c806a5ac0772458a4ef403e' into release/5.5 aab8458 update compileSdkVersion and buildToolsVersion in every subtrees 3c57356 update gradle wrapper to 2.14 3d748d5 onFeaturedImageChanged signature changed: long instead of int a3a53d3 Merge branch 'hotfix/5.4.2' into release/5.5 19170dc Use a long for featured image IDs git-subtree-dir: libs/editor git-subtree-split: eb069ba15f0a810d08d646858914bac7dfa596ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.