Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/reader redesign post detail #418

Merged
merged 35 commits into from
Dec 11, 2013
Merged

Feature/reader redesign post detail #418

merged 35 commits into from
Dec 11, 2013

Conversation

nbradbury
Copy link
Contributor

No description provided.

@nbradbury
1st pass at post detail redesign
c826ae1
@nbradbury
2nd pass at post detail redesign
1d110ec
@nbradbury
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
fe5b52f 
…ss-Android into feature/reader-redesign-post-detail
@nbradbury
Scrolling down post detail auto-hides action bar and buttons, scrolli…
41dde3f 
…ng back up re-displays them
@nbradbury
Action buttons (reblog/comment/like) in post detail now animate in/ou…
e3d130e 
…t at the same speed as the ActionBar
@nbradbury
Tweaks to follow buttons
dc1f302
@nbradbury
Added handbook color names as comments to colors.xml
658e1f0
@nbradbury
* Tags are now parsed and stored when posts are updated
2a2a236 
* Added single tag to items in post list
@nbradbury
openUrl now accepts parameters which determines whether to open passe…
cca5853 
…d url in the app or in the external browser
@nbradbury
Move likes in post detail to between the post and its comments
4d66015
@nbradbury
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
7f3d462 
…ss-Android into feature/reader-redesign-post-detail
@nbradbury
* Removed two-column view of post list, replaced with wider margins f…
149ed68 
…or landscape/tablet (more readable than two columns)

* Removed StaggeredGridView
@nbradbury
Adjusted/added reader list margins for tablets & landscape tablets
1227a8f
@nbradbury
First tag is now pre-cached before display to boost post adapter perf…
e940b33 
…ormance
@nbradbury
Added padding to post detail for extra whitespace around content & co…
c69e035 
…mments
@nbradbury
Post detail now shows featured image above content if image doesn't a…
7bfdb00 
…lready appear in the content
@nbradbury
* Featured image in post detail now shows photo viewer when tapped
7f3a2d9 
* Added "following" noticon
* Author name is only shown in post detail if different than blog name
@nbradbury
* Follow button color now defined in color resource
2aeea79 
* Removed unused resources
* Post adapter skips updating follow button when unchanged
@nbradbury
Merge branch 'develop' of https://github.com/wordpress-mobile/WordPre…
7de5fd5 
…ss-Android into feature/reader-redesign-post-detail
@nbradbury
Resolved conflicts with Maxime's PR to unify the background color
516f379
@nbradbury
* Added onDowngrade() to ReaderDatabase
f81b8f0 
* Post detail title is now set to the post's title
@nbradbury
Removed old hybrid reader
92936f1
@nbradbury
Removed tag from items in the post list (will be re-designed and adde…
c55ccdb 
…d back in next release)
@nbradbury
* Enabled follow button for non-WP posts in both list & detail views
82f715e 
* Added background color to avatar imageViews
@nbradbury
Post list position is now accurately retained after device rotation
f622f1a
@nbradbury
Minor tweaks to detail
eb32f5a
@roundhill
Copy link
Contributor

I really love how it is looking!

Usability feedback:

  • The follow button could use a highlight when tapped (selectable_background_wordpress.xml maybe?) Also the blog link and post title could use highlights.
  • Should tapping outside of the comment area in the detail view close the comment form? (probably not, but I tried to do it instinctively). I didn't know that the back/up button would close it.
  • The current reader has up/down arrows so that you can go to the next or previous post in the list without returning to the list view. Not sure how much it'll be missed but thought I'd note that we're removing a feature here.
  • Galleries still look funny: https://cloudup.com/c4O9dbo2flP
  • When the detail view loads, I see 'You like this' or 'x people like this' at the top of the view, then it gets pushed down as the content loads. Hide it at first?
  • In the comment list, a user's name is colored 'please tap me blue', but tapping it loads the comment reply view, not the user's blog.
  • The 'Nov 3' shows below my gravatar here, looks a bit unbalanced: https://cloudup.com/cooQlThleLX
  • I think this view should use the new follow button you've added in other areas: https://cloudup.com/cU0gEqcJO8p
  • It's kind of hard to see the activity indicator here: https://cloudup.com/crd4pvuv6aT
  • The detail view's padding looks a smidge too large to me, it should be 16dp on each side: https://cloudup.com/cqBDbGDp2zE

@nbradbury
* Merge branch 'develop' of https://github.com/wordpress-mobile/WordP…
bb4384c 
…ress-Android into feature/reader-redesign-post-detail

* Removed unused resources
* Liking user list now uses the same "follow" button used in the post list/detail views
* Follow buttons now show a highlight when tapped
@nbradbury
Title, blog name & author in detail view are now highlighted when tapped
f5705e1
@nbradbury
* Additional style cleanup
52de1f2 
* User name is no longer "please tap me blue" in comments
@nbradbury
Copy link
Contributor Author

Great feedback, Dan - thanks. I've corrected most of these, remarks below for the ones I didn't correct:

  • Closing the comment form when you tap outside it could be annoying if you tapped by mistake
  • I think simplifying the detail view by dropping the up/down icons will benefit more of our users than keeping this feature would
  • There's an existing issue (Native reader: better handling of galleries #275) related to the problem(s) with galleries
  • The activity indicator that appears when you post a comment seems obvious to me - how would you improve it?

@roundhill
Copy link
Contributor

The activity indicator that appears when you post a comment seems obvious to me - how would you improve it?

I think the grey on grey is what was throwing off my eyes. It's not horrible - let's just leave it.

roundhill added a commit that referenced this pull request Dec 11, 2013
@roundhill
Merge pull request #418 from wordpress-mobile/feature/reader-redesign…
dd34a3f 
…-post-detail

Feature/reader redesign post detail
@roundhill roundhill merged commit dd34a3f into develop Dec 11, 2013
@nbradbury nbradbury deleted the feature/reader-redesign-post-detail branch December 12, 2013 01:46
maxme added a commit that referenced this pull request Jun 20, 2016
@maxme
Squashed 'libs/editor/' changes from b207f3f..5ee37c8
2fc5d53 
5ee37c8 Merge pull request #419 from wordpress-mobile/js-tests
3c6a922 s/functional/unit/
04b81e3 Updated README with Mocha test instructions
4d75715 Comment cleanup
ef276fc Merge branch 'develop' into js-tests
8f06353 Added mocha tests for HTML to visual conversion
d03ea19 Merge pull request #418 from wordpress-mobile/issue/415-media-delete-paragraphs
30a3c66 Exported some Visual -> HTML conversion methods to editor-utils-formatter for testability
a53706d Merge pull request #414 from wordpress-mobile/issue/411-edit-overlay-stuck
8f3f816 Added editor-utils-formatter.js file and exported HTML->Visual formatting methods from the ZSSEditor JS
aa4bb12 Don't add extraneous break tag after videos when converting from HTML
dcbdbf1 Fix paragraph wrapping around media items when loading from HTML
7948e95 Fix duplicate src tag for videos
6470a4e Don't delete the paragraph div when deleting a media item
d189b09 Merge pull request #410 from wordpress-mobile/issue/377-video-remove-button
e13f5fc Fixed edit containers not being cleared when switching to HTML mode
eff160c Fixed #408
0acaa82 Extend contenteditable=false to the entire edit container for videos
9774ef0 Merge pull request #404 from wordpress-mobile/issue/update-html-toolbar-icon
531f368 When adding edit containers for videos in ZSSEditor.applyVisualFormatting, track them for mutation
5f0444c Add edit containers to videos when applying visual formatting
9c89dfc Remove edit containers wrapping videos when stripping visual formatting
b91317f Fixed trackNodeForMutation usage when video upload completes
3c6f61f Added a null check to ZSSEditor.sendEnabledStyles
86923d2 Track video edit containers for mutation
1a07cbf Fixed paragraph issues when adding remote videos at the start of a post
0917a1b Add delete button overlay for videos added directly (without being uploaded)
d370041 Show delete button overlay for videos that have finished uploading
546d4c6 update with new HTML icons / using a solid background on highlighted version

git-subtree-dir: libs/editor
git-subtree-split: 5ee37c8c995994edeb87651efebce57b870ff3b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@nbradbury @roundhill