-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Authenticate private resource requests #21331
Draft
dcalhoun
wants to merge
12
commits into
trunk
Choose a base branch
from
feat/authenticate-private-resource-requests
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+92
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unauthenticated requests failed when attempting to load resources from a private site, e.g., an image.
Generated by 🚫 Danger |
Project dependencies changesThe following changes in project dependencies were detected (configuration list
tree +--- project :libs:editor
| +--- com.facebook.react:react-android:0.73.3
-| | \--- com.squareup.okhttp3:okhttp-urlconnection:4.9.2
-| | +--- com.squareup.okhttp3:okhttp:4.9.2 -> 4.12.0 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
+| | \--- com.squareup.okhttp3:okhttp-urlconnection:4.9.2 -> 4.12.0
+| | +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
-| \--- org.wordpress.gutenbergkit:android:trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33
-| +--- androidx.core:core-ktx:1.13.1 (*)
-| +--- androidx.appcompat:appcompat:1.7.0 (*)
-| +--- com.google.android.material:material:1.12.0 (*)
-| +--- androidx.webkit:webkit:1.11.0 -> 1.12.1 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.0 -> 1.9.10 (*)
+| \--- org.wordpress.gutenbergkit:android:34-946b8c24e4e55e42304fa0821d27307915ef9cb8
+| +--- androidx.core:core-ktx:1.13.1 (*)
+| +--- androidx.appcompat:appcompat:1.7.0 (*)
+| +--- com.google.android.material:material:1.12.0 (*)
+| +--- androidx.webkit:webkit:1.11.0 -> 1.12.1 (*)
+| +--- com.squareup.okhttp3:okhttp-bom:4.12.0
+| | +--- com.squareup.okhttp3:okhttp:4.12.0 (c)
+| | +--- com.squareup.okhttp3:okhttp-urlconnection:4.12.0 (c)
+| | \--- com.squareup.okhttp3:logging-interceptor:4.12.0 (c)
+| +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.0 -> 1.9.10 (*)
+--- project :libs:fluxc
-| \--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2 (*)
+| \--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.12.0 (*)
-+--- org.wordpress.gutenbergkit:android:trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33 (*)
++--- org.wordpress.gutenbergkit:android:34-946b8c24e4e55e42304fa0821d27307915ef9cb8 (*)
\--- com.zendesk:support:5.1.2
\--- com.zendesk:support-providers:5.1.2
\--- com.zendesk:core:4.0.9
- \--- com.squareup.okhttp3:logging-interceptor:4.9.2
- +--- com.squareup.okhttp3:okhttp:4.9.2 -> 4.12.0 (*)
- \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
+ \--- com.squareup.okhttp3:logging-interceptor:4.9.2 -> 4.12.0
+ +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*) |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java
Fixed
Show fixed
Hide fixed
The proxy is required to authenticate the request with a bearer token.
This was added to mirror the `shouldInterceptRequest` method signature, but is unnecessary complexity.
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Description
Authenticate resource requests originating from within the WebView so that
requests to private sites succeed.
To Test:
See wordpress-mobile/GutenbergKit#34.
Regression Notes
Gutenberg Mobile or Aztec editors fail.
Manually tested both editors.
None, feels unnecessary for this currently experimental editor feature.
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):