Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump :gravatar to 2.0.0 #21311

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Bump :gravatar to 2.0.0 #21311

wants to merge 1 commit into from

Conversation

AdamGrzybkowski
Copy link
Contributor

@AdamGrzybkowski AdamGrzybkowski commented Oct 18, 2024

This PR bumps the Gravatar SDK to the latest 2.0.0 version.

WP-Login needs to be updated as well, so for now, I used the build from a PR. I think it's best to wait for this PR to be merged first.

To Test:

Avatar change flow from the Me tab.


Regression Notes

  1. Potential unintended areas of impact

    • TODO
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • TODO
  3. What automated tests I added (or what prevented me from doing so)

    • TODO

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@AdamGrzybkowski AdamGrzybkowski added the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Oct 18, 2024
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 18, 2024

Project dependencies changes

The following changes in project dependencies were detected (configuration wordpressVanillaReleaseRuntimeClasspath):

list
New Dependencies
com.squareup.moshi:moshi:1.15.1
com.squareup.moshi:moshi-kotlin:1.15.1
com.squareup.retrofit2:converter-moshi:2.11.0
org.jetbrains.kotlin:kotlin-reflect:1.8.22

Upgraded Dependencies
com.gravatar:gravatar:2.0.0, (changed from 1.0.0)
tree
-+--- project :libs:login
-|    \--- com.gravatar:gravatar:0.2.0 -> 1.0.0
-|         +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0
-|         |    \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
-|         +--- com.squareup.retrofit2:converter-gson:2.9.0
-|         |    +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0 (*)
-|         |    \--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*)
-|         +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*)
-|         +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.0 (*)
++--- project :libs:image-editor
+|    \--- com.google.android.material:material:1.12.0
+|         \--- org.jetbrains.kotlin:kotlin-bom:1.8.22
+|              \--- org.jetbrains.kotlin:kotlin-reflect:1.8.22 (c)
-+--- com.gravatar:gravatar:1.0.0 (*)
-\--- com.zendesk:support:5.1.2
-     \--- com.zendesk:support-providers:5.1.2
-          \--- com.zendesk:core:4.0.9
-               \--- com.squareup.retrofit2:converter-gson:2.9.0 (*)
++--- project :libs:login
+|    \--- com.gravatar:gravatar:2.0.0
+|         +--- com.squareup.moshi:moshi-kotlin:1.15.1
+|         |    +--- com.squareup.moshi:moshi:1.15.1
+|         |    |    +--- com.squareup.okio:okio:3.7.0 -> 3.9.0 (*)
+|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+|         |    +--- org.jetbrains.kotlin:kotlin-reflect:1.8.21 -> 1.8.22
+|         |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+|         +--- com.squareup.retrofit2:retrofit:2.11.0
+|         |    \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
+|         +--- com.squareup.retrofit2:converter-moshi:2.11.0
+|         |    +--- com.squareup.retrofit2:retrofit:2.11.0 (*)
+|         |    \--- com.squareup.moshi:moshi:1.15.1 (*)
+|         +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*)
+|         +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.0 (*)
++--- com.gravatar:gravatar:2.0.0 (*)
+\--- com.zendesk:support:5.1.2
+     \--- com.zendesk:support-providers:5.1.2
+          \--- com.zendesk:core:4.0.9
+               \--- com.squareup.retrofit2:converter-gson:2.9.0
+                    +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0 (*)
+                    \--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 18, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21311-53bc90f
Commit53bc90f
Direct Downloadwordpress-prototype-build-pr21311-53bc90f.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 18, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21311-53bc90f
Commit53bc90f
Direct Downloadjetpack-prototype-build-pr21311-53bc90f.apk
Note: Google Login is not supported on these builds.

Copy link

sonarcloud bot commented Oct 25, 2024

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 39.30%. Comparing base (b3b94e5) to head (53bc90f).
Report is 4 commits behind head on trunk.

Files with missing lines Patch % Lines
...a/org/wordpress/android/login/util/AvatarHelper.kt 0.00% 7 Missing ⚠️
...java/org/wordpress/android/util/WPAvatarUtils.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #21311      +/-   ##
==========================================
- Coverage   39.31%   39.30%   -0.01%     
==========================================
  Files        2121     2121              
  Lines       98299    98307       +8     
  Branches    15226    15226              
==========================================
  Hits        38644    38644              
- Misses      56220    56228       +8     
  Partials     3435     3435              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants