Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Persist feed selection across sessions #20402

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

thomashorta
Copy link
Contributor

Fixes #20127
Fixes #20183

Cherry-picking the changes from #20306 to target the current release version.

We decided to push these changes to our users ASAP since it seems to be the biggest cause of complaints and frustrations for Reader users after the navigation update. Internal ref: p1709575185407929-slack-CC7L49W13

Original PR (#20306) message:

This PR ends up fixing 2 issues since fixing #20127 made the problem from #20183 happen more often. Both fixes are on the small side so I decided to do both in the same PR.


To Test:

Testing Reader feed selection persistence

  1. Open the Jetpack app
  2. Go to Reader
  3. Select any feed that's not Discover
  4. Close the app and kill it from the "Recent Apps" screen
  5. Open the Jetpack app again
  6. Verify the same feed is still selected

Other test steps can be found here as well: #20127 (comment)

Testing "empty state" text showing up even when there are posts in the list

This is a bit trickier to test, but the steps listed by @daniloercoli in the original issue should do:

  1. Open the Reader on a list or a feed that doesn't have content
  2. Move to another feed
  3. Verify the empty state message is hidden

Regression Notes

  1. Potential unintended areas of impact

    • Problems in the "empty state" visibility state
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    • N/A, the unit tests are still not up-to-date in this part of the code so it was not possible to add it currently

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…list

Cherry-picking the changes from #20306 to target the current release version.
@thomashorta thomashorta added this to the 24.3 milestone Mar 4, 2024
@thomashorta thomashorta self-assigned this Mar 4, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.3. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20402-0cb56bd
Commit0cb56bd
Direct Downloadwordpress-prototype-build-pr20402-0cb56bd.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20402-0cb56bd
Commit0cb56bd
Direct Downloadjetpack-prototype-build-pr20402-0cb56bd.apk
Note: Google Login is not supported on these builds.

@thomashorta thomashorta requested a review from develric March 4, 2024 18:57
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 40.18%. Comparing base (5efed33) to head (0cb56bd).

Files Patch % Lines
...ss/android/ui/reader/viewmodels/ReaderViewModel.kt 41.66% 5 Missing and 2 partials ⚠️
.../java/org/wordpress/android/ui/prefs/AppPrefs.java 0.00% 5 Missing ⚠️
.../org/wordpress/android/ui/prefs/AppPrefsWrapper.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/24.3   #20402      +/-   ##
================================================
- Coverage         40.18%   40.18%   -0.01%     
================================================
  Files              1469     1469              
  Lines             67665    67677      +12     
  Branches          11208    11209       +1     
================================================
+ Hits              27193    27197       +4     
- Misses            37978    37986       +8     
  Partials           2494     2494              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @thomashorta ! I've tested every scenario listed in this PR and it's working as expected. Code LGTM :shipit:

@thomashorta thomashorta merged commit d8b8dbe into release/24.3 Mar 4, 2024
20 of 23 checks passed
@thomashorta thomashorta deleted the hotfix/reader-persist-feed-selection branch March 4, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants