-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader] Persist feed selection across sessions #20402
Conversation
…list Cherry-picking the changes from #20306 to target the current release version.
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/24.3 #20402 +/- ##
================================================
- Coverage 40.18% 40.18% -0.01%
================================================
Files 1469 1469
Lines 67665 67677 +12
Branches 11208 11209 +1
================================================
+ Hits 27193 27197 +4
- Misses 37978 37986 +8
Partials 2494 2494 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @thomashorta ! I've tested every scenario listed in this PR and it's working as expected. Code LGTM
Fixes #20127
Fixes #20183
Cherry-picking the changes from #20306 to target the current release version.
We decided to push these changes to our users ASAP since it seems to be the biggest cause of complaints and frustrations for Reader users after the navigation update. Internal ref: p1709575185407929-slack-CC7L49W13
Original PR (#20306) message:
To Test:
Testing Reader feed selection persistence
Discover
Other test steps can be found here as well: #20127 (comment)
Testing "empty state" text showing up even when there are posts in the list
This is a bit trickier to test, but the steps listed by @daniloercoli in the original issue should do:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist: