Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bar size issue on traffic tab #20340

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Feb 29, 2024

Fixes #20335

This fixes the incorrect bar height issue on the traffic tab.

  • Removed granularity as it was necessary for the zoom feature, which we don't use. 8394773
  • Set min-max values for the left axis since the data depends on the left axis. 10bbe8e
before after

To Test:

  1. Open the Stats Traffic tab (currently behind a feature flag)
  2. Switch to By week and compare the View count to WP.com
  3. Switch to By month and compare the View count to WP.com

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • This issue is caused by the settings of a 3rd part lib for the chart. It's not proper to add UI tests for this minor issue.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

granularity is necessary for the zoom feature on the chart. Zoom feature is not being used, so granularity is unnecessary.
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.4. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20340-10bbe8e
Commit10bbe8e
Direct Downloadjetpack-prototype-build-pr20340-10bbe8e.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20340-10bbe8e
Commit10bbe8e
Direct Downloadwordpress-prototype-build-pr20340-10bbe8e.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@notandyvee notandyvee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20240229_175659

Works for me. The numbers are slightly higher. Could could have changed since it's today. But not to the degree it was before. Could you double check you also see the view increase? Merge if it looks good. Good work.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this 👍

@ravishanker ravishanker merged commit df9fc91 into trunk Feb 29, 2024
20 of 24 checks passed
@ravishanker ravishanker deleted the issue/20335-fix-bar-size-issue-on-traffic-tab branch February 29, 2024 23:24
@irfano irfano added the Stats label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats Traffic chart counts show incorrect values
5 participants