Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Change comment subscribe action label to "Follow" #20119

Merged

Conversation

thomashorta
Copy link
Contributor

Fixes #20118

20118-reader-comments-follow


To Test:

  1. Go to Reader
  2. Tap on a Post with comments to open Post Details
  3. Tap on "Comments" or scroll down and tap "View all comments"
  4. Verifty the menu action says "Follow" instead of "Subscribe"

Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

N/A

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@thomashorta thomashorta self-assigned this Feb 3, 2024
@thomashorta thomashorta changed the base branch from trunk to feature/reader-ia February 3, 2024 15:59
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 3, 2024

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

+\--- me.saket.cascade:cascade-compose:2.3.0
+     +--- androidx.activity:activity-compose:1.7.2 -> 1.8.0 (*)
+     +--- androidx.compose.ui:ui:1.5.2 -> 1.5.3 (*)
+     +--- androidx.compose.ui:ui-tooling:1.5.2 -> 1.5.3 (*)
+     +--- androidx.compose.foundation:foundation:1.5.2 -> 1.5.3 (*)
+     +--- androidx.compose.material3:material3:1.1.2 (*)
+     \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20119-1779dfd
Commit1779dfd
Direct Downloadjetpack-prototype-build-pr20119-1779dfd.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20119-1779dfd
Commit1779dfd
Direct Downloadwordpress-prototype-build-pr20119-1779dfd.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @thomashorta 🙇 , works as expected and LGTM :shipit:

Note: just noting for the future us, that this CI comment is not true, but was triggered by the PR initially targeting trunk by mistake. No dependency tree changes in this PR that only changes string resources 👍

@develric develric merged commit 1776c29 into feature/reader-ia Feb 3, 2024
20 of 26 checks passed
@develric develric deleted the issue/20118-reader-ia-comments-action-string branch February 3, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reader] Follow comments action should not be "Subscribe" in comment details
4 participants