-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader] Change comment subscribe action label to "Follow" #20119
[Reader] Change comment subscribe action label to "Follow" #20119
Conversation
Generated by 🚫 dangerJS |
Generated by 🚫 Danger |
Found 1 violations: The PR caused the following dependency changes:+\--- me.saket.cascade:cascade-compose:2.3.0
+ +--- androidx.activity:activity-compose:1.7.2 -> 1.8.0 (*)
+ +--- androidx.compose.ui:ui:1.5.2 -> 1.5.3 (*)
+ +--- androidx.compose.ui:ui-tooling:1.5.2 -> 1.5.3 (*)
+ +--- androidx.compose.foundation:foundation:1.5.2 -> 1.5.3 (*)
+ +--- androidx.compose.material3:material3:1.1.2 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
Please review and act accordingly
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @thomashorta 🙇 , works as expected and LGTM
Note: just noting for the future us, that this CI comment is not true, but was triggered by the PR initially targeting trunk by mistake. No dependency tree changes in this PR that only changes string resources 👍
Fixes #20118
To Test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist:
N/A