Deprecate org.wordpress-mobile dependency group in favor of org.wordpress #19989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19989-2665165 | |
| Commit | 2665165 | |
| Direct Download | jetpack-prototype-build-pr19989-2665165.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19989-2665165 | |
| Commit | 2665165 | |
| Direct Download | wordpress-prototype-build-pr19989-2665165.apk |
fluiddot
approved these changes
Jan 19, 2024
Comment on lines
+44
to
+45
| // 'org.wordpress-mobile' group is deprecated. It's kept for now for smoother transition | ||
| // but it should be removed soon (within couple weeks) |
There was a problem hiding this comment.
We could remove org.wordpress-mobile once version 24.1 is code frozen and we generate an alpha version of Gutenberg Mobile to include changes from WordPress/gutenberg#58017.
oguzkocer
deleted the
add/org_wordpress_react-native-libraries_repository
branch
|
@oguzkocer I'm encountering issues after this change and WordPress/gutenberg#58017 when publishing a new GBM version and pointing it in the following line: WordPress-Android/build.gradle Line 26 in eefbd25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of abundance of caution, we are updating the group id used to publish
gutenberg-mobileartifacts fromorg.wordpress-mobiletoorg.wordpresssince we don't own thewordpress-mobiledomain. Instead of removing the old group id, I opted to deprecate it for now for smoother transition for developers. I intend to remove these deprecated domains some time next week.I didn't test this because the artifacts are not ready yet, but it's a straightforward change and one that can't break anything. So, my suggestion is to merge it and address any issues once the artifacts are updated.