-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Properly space Day One name #19977
Conversation
The Day One brand name includes a space between the two words.
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Generated by 🚫 dangerJS |
Treat translation strings as immutable to avoid discrepancies between releases and the `trunk` branch.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #19977 +/- ##
=======================================
Coverage 40.45% 40.45%
=======================================
Files 1440 1440
Lines 66513 66513
Branches 10957 10957
=======================================
Hits 26905 26905
Misses 37121 37121
Partials 2487 2487 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, thanks @dcalhoun !
The Day One brand name includes a space between the two words.
Screenshots
To Test:
Check out the branch and apply the following testing diff:
Testing Diff
Build and launch the app.
Load the My Site tab and verify the "Day One" name in the Blogging Prompt attribution includes a space.
Regression Notes
Blogging Prompts, translations.
Interacted with Blogging Prompts, test different device languages.
Automated tests felt unnecessary for a typo.
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: