[Reader] reader_accessed event not triggerered when app is resumed #19960

RenanLukas · 2024-01-16T19:10:30Z

Fixes #19278

To Test:

1 - Install JP and sign in;
2 - Verify the selected tab correct analytics event is tracked:

- Reader: 🔵 Tracked: reader_accessed
- My Site: 🔵 Tracked: my_site_tab_accessed, Properties: {"blog_id":<id>,"site_type":"blog","is_jetpack":false}
- Notifications: 🔵 Tracked: notifications_accessed
- Me: 🔵 Tracked: me_tab_accessed

3 - Send the app to background (e.g. tap home button) and open it again: the event from step 2 should be tracked again (previously this wasn't happening);
4 - Repeat steps 2-3 with the four tabs.

Regression Notes

Potential unintended areas of impact
- None
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual testing
What automated tests I added (or what prevented me from doing so)
- This logic is currently implemented in Activity.

PR Submission Checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
Talkback.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
Large and small screen sizes. (Tablet and smaller phones)
Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

…ume is called

wpmobilebot · 2024-01-16T19:28:21Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19960-bc98e2a
	Commit	`bc98e2a`
	Direct Download	`wordpress-prototype-build-pr19960-bc98e2a.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2024-01-16T19:30:08Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19960-bc98e2a
	Commit	`bc98e2a`
	Direct Download	`jetpack-prototype-build-pr19960-bc98e2a.apk`

Note: Google Login is not supported on these builds.

thomashorta

I found a behavior that I am not 100% sure we want, so I added a comment in the appropriate part of the code.

thomashorta · 2024-01-16T21:46:01Z

WordPress/src/main/java/org/wordpress/android/ui/main/WPMainActivity.java

@@ -1135,7 +1131,7 @@ protected void onResume() {

        if (mBottomNav != null) {
            PageType currentPageType = mBottomNav.getCurrentSelectedPage();
-            trackLastVisiblePage(currentPageType, mFirstResume);
+            trackLastVisiblePage(currentPageType);


⚠️ Something I noticed after these changes is that now the events are tracked when the device rotates, which doesn't seem desirable.

In case we don't want to track on orientation changes, one idea is to keep some flag and add some logic related to saving and restoring instance state. I didn't double check, but these seem to be the Lifecycle callbacks order during orientation change, so we can probably differentiate between:

Orientation change with app in foreground (onSaveInstanceState called before onStop) -> should not track the event again when reaching this line inside onResume;

App in background and killed by the system to reclaim memory ( onSaveInstanceState called after onStop) -> should track the event again when reaching this line inside onResume.

But this is just something I thought now, there might be other ways of making sure we track only when we want.

Good catch, thanks

I'm fixing it

Noticed some events that are tracked twice.

When I tap on the Reader Tab the first time

Tracked: reader_accessed
2024-01-23 09:34:15.463 16331-16331 WordPress-STATS com.jetpack.android.prealpha

Tracked: reader_filter_sheet_item_selected
2024-01-23 09:34:15.518 16331-16331 WordPress-STATS com.jetpack.android.prealpha

Tracked: reader_filter_sheet_item_selected
2024-01-23 09:34:15.810 16331-16331 WordPress-STATS com.jetpack.android.prealpha

Tracked: reader_following_shown

I see 2 distinct reader_filter_sheet_item_selected events tracked in analytics.

Rotate the device
Every time i rotate the device i see 2 new reader_filter_sheet_item_selected events, together with deep_link_not_default_handler event, bumped to analytics.

Tracked: deep_link_not_default_handler, Properties: {"interceptor_classname":"org.wordpress.android.WPComPostReaderActivity"}
2024-01-23 09:35:42.628 16331-16331 WordPress-STATS com.jetpack.android.prealpha

Tracked: reader_filter_sheet_item_selected
2024-01-23 09:35:42.676 16331-16331 WordPress-STATS com.jetpack.android.prealpha

Tracked: reader_filter_sheet_item_selected

Open the single post details view
The event reader_article_rendered is tracked multiple times.

Tracked: reader_post_card_tapped, Properties: {"blog_id":0,"feed_id":35393375,"follow":true,"source":"following"}
2024-01-23 09:40:11.089 16331-16331 WordPress-STATS com.jetpack.android.prealpha

Tracked: app_reviews_significant_event_incremented, Properties: {"source":"opening_reader_post"}
2024-01-23 09:40:11.451 16331-16331 WordPress-STATS com.jetpack.android.prealpha

Tracked: reader_article_opened, Properties: {"follow":true,"feed_id":35393375,"feed_item_id":5086693692,"is_jetpack":false,"site_type":"blog"}
2024-01-23 09:40:11.599 16331-16331 WordPress-STATS com.jetpack.android.prealpha

Tracked: reader_article_rendered, Properties: {"follow":true,"feed_id":35393375,"feed_item_id":5086693692,"is_jetpack":false,"site_type":"blog"}
2024-01-23 09:40:11.623 16331-16331 WordPress-STATS com.jetpack.android.prealpha

Tracked: reader_article_rendered, Properties: {"follow":true,"feed_id":153742481,"feed_item_id":5086695973,"is_jetpack":false,"site_type":"blog"}

Going back to the reader from the Single post details view
I see the event reader_accessed is tracked again. Not sure we'd like to bump this again here.

Thanks for finding these tracking issues, @daniloercoli

Since they're not related to this PR, I've created a new issue to take care of it.

…hanged

peril-wordpress-mobile · 2024-01-18T18:58:03Z

	Warnings
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS

RenanLukas · 2024-01-18T19:00:18Z

Thanks for the review, @thomashorta

I've fixed the issue you've mentioned and now the event is not tracked when the screen orientation changes. It's still tracked when the system kills the app and the Activity is recreated (I've tested this using Don't Keep Activities under developer options).

dangermattic · 2024-01-18T21:36:01Z

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

thomashorta

Thanks for the addition of the "isChangingConfiguration" check, it looks like it works as desired now!

I see @daniloercoli added some other concerns about other Reader analytics events that are being triggered multiple times (#19960 (comment)). I think it would be worth taking a look at them, but as another GH issue/PR, as it is not in the scope of the current PR.

daniloercoli

LGTM!

Track bottom navigation tab accessed analytics event every time onRes…

fe4d590

…ume is called

RenanLukas added Reader [Type] Task labels Jan 16, 2024

RenanLukas marked this pull request as ready for review January 16, 2024 19:11

RenanLukas requested review from thomashorta and develric January 16, 2024 19:11

daniloercoli self-requested a review January 16, 2024 19:56

daniloercoli self-assigned this Jan 16, 2024

thomashorta reviewed Jan 16, 2024

View reviewed changes

Fix PR comment: prevent tracking tab accessed if screen orientation c…

7456738

…hanged

Remove wrong return added to main activity onResume

bc98e2a

thomashorta approved these changes Jan 23, 2024

View reviewed changes

RenanLukas mentioned this pull request Jan 23, 2024

[Reader] Some analytics events are being tracked twice #20006

Closed

daniloercoli approved these changes Jan 23, 2024

View reviewed changes

RenanLukas merged commit d651b40 into feature/reader-ia Jan 23, 2024
20 checks passed

RenanLukas deleted the issue/19278-reader-accessed-event-not-triggerered-app-background-and-back branch January 23, 2024 18:36

thomashorta mentioned this pull request Feb 3, 2024

[Reader] Improve content navigation and filtering #19978

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Reader] reader_accessed event not triggerered when app is resumed #19960

[Reader] reader_accessed event not triggerered when app is resumed #19960

RenanLukas commented Jan 16, 2024 •

edited

Loading

wpmobilebot commented Jan 16, 2024 •

edited

Loading

wpmobilebot commented Jan 16, 2024 •

edited

Loading

thomashorta left a comment

thomashorta Jan 16, 2024

RenanLukas Jan 18, 2024

daniloercoli Jan 23, 2024 •

edited

Loading

RenanLukas Jan 23, 2024

peril-wordpress-mobile bot commented Jan 18, 2024

RenanLukas commented Jan 18, 2024

dangermattic commented Jan 18, 2024

thomashorta left a comment

daniloercoli left a comment

[Reader] reader_accessed event not triggerered when app is resumed #19960

[Reader] reader_accessed event not triggerered when app is resumed #19960

Conversation

RenanLukas commented Jan 16, 2024 • edited Loading

To Test:

Regression Notes

PR Submission Checklist:

UI Changes Testing Checklist:

wpmobilebot commented Jan 16, 2024 • edited Loading

wpmobilebot commented Jan 16, 2024 • edited Loading

thomashorta left a comment

Choose a reason for hiding this comment

thomashorta Jan 16, 2024

Choose a reason for hiding this comment

RenanLukas Jan 18, 2024

Choose a reason for hiding this comment

daniloercoli Jan 23, 2024 • edited Loading

Choose a reason for hiding this comment

RenanLukas Jan 23, 2024

Choose a reason for hiding this comment

peril-wordpress-mobile bot commented Jan 18, 2024

RenanLukas commented Jan 18, 2024

dangermattic commented Jan 18, 2024

thomashorta left a comment

Choose a reason for hiding this comment

daniloercoli left a comment

Choose a reason for hiding this comment

RenanLukas commented Jan 16, 2024 •

edited

Loading

wpmobilebot commented Jan 16, 2024 •

edited

Loading

wpmobilebot commented Jan 16, 2024 •

edited

Loading

daniloercoli Jan 23, 2024 •

edited

Loading