Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats traffic tab add traffic tab #19942

Merged
merged 12 commits into from
Jan 15, 2024
Merged

Conversation

ravishanker
Copy link
Contributor

@ravishanker ravishanker commented Jan 15, 2024

Fixes #19941


Before After
Screenshot_20240115_163157 Screenshot_20240115_163256

To Test:

Test 1:

  • Enable stats_traffic_tab feature flag (Me -> Debug settings - Remote Features)
  • Go to Stats
  • Verify only Traffic tab, and Insights tabs are shown as in after column

Note

Traffic tab is set to show Days tab for the time being since except for the first card with graph, the rest of the cards remain same.

Test 2:

  • Disable feature flag
  • Verify Stats tabs all show up as in before column, and work as before

Regression Notes

  1. Potential unintended areas of impact

    • Tested various combinations
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Tested manually
  3. What automated tests I added (or what prevented me from doing so)

    • Existing unit tests

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Add Traffic string resource
Add TRAFFIC to Stats Section
Add traffic tab, and exclude days, weeks, months, and years when feature flag is enabled
Add Traffic stats section
Add traffic stats section
Add traffic stats section mapping to Days for the time being
add traffic event
Add traffic event, and map to days property for the time being
Add traffic to tracking
@ravishanker ravishanker added this to the 24.1 milestone Jan 15, 2024
@ravishanker ravishanker requested a review from irfano January 15, 2024 06:00
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 15, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19942-e373e2c
Commite373e2c
Direct Downloadwordpress-prototype-build-pr19942-e373e2c.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 15, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19942-e373e2c
Commite373e2c
Direct Downloadjetpack-prototype-build-pr19942-e373e2c.apk
Note: Google Login is not supported on these builds.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just removed an extra line (e373e2c).
Simple change. It did not impact other areas and the state of the disabled flag. LGTM! 👍🏻

@ravishanker ravishanker merged commit e82d46b into trunk Jan 15, 2024
19 checks passed
@ravishanker ravishanker deleted the Stats-Traffic-Tab-Add-traffic-tab branch January 15, 2024 22:22
@ravishanker ravishanker self-assigned this Jan 16, 2024
@irfano irfano added the Stats label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stats Traffic: Add Traffic tab when feature is enabled
3 participants