-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader IA] Add dropdown menu analytics events #19911
Merged
RenanLukas
merged 7 commits into
feature/reader-ia
from
issue/19906-reader-ia-implement-analytics-events-dropdown-menu
Jan 16, 2024
Merged
[Reader IA] Add dropdown menu analytics events #19911
RenanLukas
merged 7 commits into
feature/reader-ia
from
issue/19906-reader-ia-implement-analytics-events-dropdown-menu
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
RenanLukas
force-pushed
the
issue/19906-reader-ia-implement-analytics-events-dropdown-menu
branch
from
January 10, 2024 19:24
b1fc078
to
dd30f9c
Compare
…-analytics-events-dropdown-menu
Generated by 🚫 dangerJS |
Generated by 🚫 Danger |
daniloercoli
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
RenanLukas
deleted the
issue/19906-reader-ia-implement-analytics-events-dropdown-menu
branch
January 16, 2024 22:08
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19906
To Test:
"Reader"
;Regression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing and unit tests.
What automated tests I added (or what prevented me from doing so)
Updated
ReaderTrackerTest.kt
.PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: