Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader IA] Add dropdown menu analytics events #19911

Conversation

RenanLukas
Copy link
Contributor

@RenanLukas RenanLukas commented Jan 9, 2024

Fixes #19906


To Test:

  • Install JP and sign-in;
  • Open "Reader";
  • Tap on the drop-down menu: you should see the following analytics event in the Logcat:
🔵 Tracked: reader_dropdown_menu_opened
  • Tap each item in the drop-down menu (including a custom list item). You should see the following analytics events being tracked:
// When "Discover" is tapped
🔵 Tracked: reader_dropdown_menu_item_tapped, Properties: {"id":"discover"}
// When "Subscriptions" is tapped
🔵 Tracked: reader_dropdown_menu_item_tapped, Properties: {"id":"following"}
// When "Saved" is tapped
🔵 Tracked: reader_dropdown_menu_item_tapped, Properties: {"id":"saved"}
// When "Liked" is tapped
🔵 Tracked: reader_dropdown_menu_item_tapped, Properties: {"id":"liked"}
// When "Automattic" is tapped
🔵 Tracked: reader_dropdown_menu_item_tapped, Properties: {"id":"a8c"}
// When any item in a custom list is tapped (Menu -> Lists -> Tap any item)
🔵 Tracked: reader_dropdown_menu_item_tapped, Properties: {"id":"list"}

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing and unit tests.

  3. What automated tests I added (or what prevented me from doing so)
    Updated ReaderTrackerTest.kt.


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 9, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19911-b581541
Commitb581541
Direct Downloadwordpress-prototype-build-pr19911-b581541.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 9, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19911-b581541
Commitb581541
Direct Downloadjetpack-prototype-build-pr19911-b581541.apk
Note: Google Login is not supported on these builds.

@RenanLukas RenanLukas force-pushed the issue/19906-reader-ia-implement-analytics-events-dropdown-menu branch from b1fc078 to dd30f9c Compare January 10, 2024 19:24
@RenanLukas RenanLukas marked this pull request as ready for review January 10, 2024 21:14
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@daniloercoli daniloercoli self-requested a review January 16, 2024 18:15
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@RenanLukas RenanLukas merged commit 3358440 into feature/reader-ia Jan 16, 2024
19 checks passed
@RenanLukas RenanLukas deleted the issue/19906-reader-ia-implement-analytics-events-dropdown-menu branch January 16, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants