Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Enable Network Connectivity status and retry all failed media uploads #19857

Closed
wants to merge 22 commits into from

Conversation

derekblank
Copy link
Contributor

@derekblank derekblank commented Dec 29, 2023

Test PR to create installable builds for testing network connectivity status in the editor and retrying all failed media uploads.

Refs:

@derekblank derekblank added Gutenberg Editing and display of Gutenberg blocks. Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging labels Dec 29, 2023
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 29, 2023

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 29, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19857-98b608c
Commit98b608c
Direct Downloadwordpress-prototype-build-pr19857-98b608c.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 29, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19857-98b608c
Commit98b608c
Direct Downloadjetpack-prototype-build-pr19857-98b608c.apk
Note: Google Login is not supported on these builds.

derekblank and others added 21 commits December 29, 2023 15:09
This is an exploration. The approach taken, namely using the error type
string, is not fully tested.
Ensure the implementation adheres to the relevant interface.
With the addition of a discrete paused method, we no longer utilize this
parameter in the failed method.
We do not plan to add paused media support to the Aztec editor.
Therefore, it likely makes more sense for the `onMediaUploadPaused`
implementation to merely invoke the existing `onMediaUploadFailed`
method.
Without checking for an error, there may be a possibility that
successfully uploaded media is marked as "paused."
Even though we communicate a nuanced paused state to the user, we likely
need to continue tracking this event as a failure, or consider adding a
discrete pause analytic event.
Based upon existing code, we should consider completed uploads lacking
remote URLs to be failures. Therefore, we should apply the new pause
state to this context.
…ck-upload-visuals__discrete-paused-state

Add discrete onMediaUploadPaused handler to media uploads when offline
… into feat/update-image-block-upload-visuals
@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

 \--- project :libs:editor
-     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.110.0
-          +--- com.facebook.fresco:animated-gif:2.0.0
-          |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
-          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |    \--- com.facebook.fresco:animated-base:2.0.0
-          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:animated-drawable:2.0.0
-          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
-          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         \--- com.parse.bolts:bolts-tasks:1.4.0
-          +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
-          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-6
-          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    |    \--- com.google.guava:guava:27.1-android
-          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-          |    |         \--- androidx.media:media:1.2.1 (*)
-          |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
-          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.11.0 (*)
-          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.11.0 (*)
-          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-4
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-get-random-values:1.4.0
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-safe-area-context:4.6.3
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.10 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-screens:3.22.0
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.9.10 (*)
-          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
-          |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-          |    +--- com.google.android.material:material:1.1.0 -> 1.9.0 (*)
-          |    \--- androidx.core:core-ktx:1.5.0 -> 1.10.0 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-svg:13.9.0
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-webview:11.26.1
-          |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.10 (*)
-          |    \--- androidx.webkit:webkit:1.4.0 -> 1.7.0 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-masked-view:0.2.9
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-clipboard:1.11.2
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-fast-image:8.5.11
-          |    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1
-          |    |    +--- com.github.bumptech.glide:gifdecoder:4.15.1
-          |    |    |    \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
-          |    |    +--- com.github.bumptech.glide:disklrucache:4.15.1
-          |    |    +--- com.github.bumptech.glide:annotations:4.15.1
-          |    |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
-          |    |    +--- androidx.exifinterface:exifinterface:1.3.3 -> 1.3.6 (*)
-          |    |    \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
-          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-          |         +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1 (*)
-          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.11.0 (*)
-          |         \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-gesture-handler:2.10.2
-          |    +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
-          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
-          |    +--- androidx.core:core-ktx:1.6.0 -> 1.10.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.9.10 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-linear-gradient:2.7.3
-          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.110.0
-          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-          |    +--- androidx.gridlayout:gridlayout:1.0.0
-          |    |    +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
-          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-          |    +--- androidx.cardview:cardview:1.0.0 (*)
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
-          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
-          |    +--- org.wordpress:aztec:v1.9.0 (*)
-          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.9.0 (*)
-          |    +--- org.wordpress.aztec:wordpress-comments:v1.9.0 (*)
-          |    +--- org.wordpress.aztec:glide-loader:v1.9.0
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-          |    |    +--- org.wordpress:aztec:v1.9.0 (*)
-          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:6509-2d1ba0463bf2b40c1e2ee17fdee05e5d6bb04bfa
+          +--- com.facebook.fresco:animated-gif:2.0.0
+          |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |    \--- com.facebook.fresco:animated-base:2.0.0
+          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:animated-drawable:2.0.0
+          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         \--- com.parse.bolts:bolts-tasks:1.4.0
+          +--- com.google.android.material:material:1.2.1 -> 1.9.0 (*)
+          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-6
+          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    |    \--- com.google.guava:guava:27.1-android
+          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
+          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+          |    |         \--- androidx.media:media:1.2.1 (*)
+          |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    +--- androidx.core:core:1.1.0 -> 1.10.0 (*)
+          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.11.0 (*)
+          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.11.0 (*)
+          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-4
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-get-random-values:1.4.0
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-safe-area-context:4.6.3
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.20 -> 1.9.10 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-screens:3.22.0
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.21 -> 1.9.10 (*)
+          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
+          |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
+          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+          |    +--- com.google.android.material:material:1.1.0 -> 1.9.0 (*)
+          |    \--- androidx.core:core-ktx:1.5.0 -> 1.10.0 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-svg:13.9.0
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-webview:11.26.1
+          |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.10 (*)
+          |    \--- androidx.webkit:webkit:1.4.0 -> 1.7.0 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-masked-view:0.2.9
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-clipboard:1.11.2
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-fast-image:8.5.11
+          |    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1
+          |    |    +--- com.github.bumptech.glide:gifdecoder:4.15.1
+          |    |    |    \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
+          |    |    +--- com.github.bumptech.glide:disklrucache:4.15.1
+          |    |    +--- com.github.bumptech.glide:annotations:4.15.1
+          |    |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
+          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+          |    |    +--- androidx.exifinterface:exifinterface:1.3.3 -> 1.3.6 (*)
+          |    |    \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
+          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+          |         +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1 (*)
+          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.11.0 (*)
+          |         \--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-gesture-handler:2.10.2
+          |    +--- org.wordpress-mobile.react-native-libraries.v3:react-native-reanimated:2.17.0
+          |    +--- androidx.appcompat:appcompat:1.4.1 -> 1.6.1 (*)
+          |    +--- androidx.core:core-ktx:1.6.0 -> 1.10.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.9.10 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v3:react-native-linear-gradient:2.7.3
+          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:6509-2d1ba0463bf2b40c1e2ee17fdee05e5d6bb04bfa
+          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+          |    +--- androidx.gridlayout:gridlayout:1.0.0
+          |    |    +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
+          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+          |    +--- androidx.cardview:cardview:1.0.0 (*)
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.6.1 (*)
+          |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.3.0 (*)
+          |    +--- org.wordpress:aztec:v1.9.0 (*)
+          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.9.0 (*)
+          |    +--- org.wordpress.aztec:wordpress-comments:v1.9.0 (*)
+          |    +--- org.wordpress.aztec:glide-loader:v1.9.0
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+          |    |    +--- org.wordpress:aztec:v1.9.0 (*)
+          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)

Please review and act accordingly

@wordpress-mobile wordpress-mobile deleted a comment from wpmobilebot Jan 9, 2024
@dcalhoun dcalhoun closed this Jan 11, 2024
@dcalhoun dcalhoun deleted the rnmobile/test-upload-offline-ux branch January 11, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants