-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prompts] Fix response list paging regression #19730
Merged
thomashorta
merged 2 commits into
release/23.8
from
issue/19728-prompts-view-responses-pagination
Dec 5, 2023
Merged
[Prompts] Fix response list paging regression #19730
thomashorta
merged 2 commits into
release/23.8
from
issue/19728-prompts-view-responses-pagination
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fixed code was removed because of an old PR that was recently rebased and I didn't realize it reverted the proper behavior as it was originally made on top of an older version containing this bug. Culprit PR: #18340
Generated by 🚫 dangerJS |
thomashorta
changed the title
[Prompts] Fix responses paging regression
[Prompts] Fix response list paging regression
Dec 4, 2023
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
RenanLukas
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It's working as expected
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19728
The correct code was already in production until the release of 23.7, when it was removed because of an old PR (created before the correct code fix was merged in the past) that was rebased and I didn't realize it reverted to the wrong behavior.
PR that introduced the regression: #18340
This PR basically reintroduces the fix made by #18276 that was reverted by the culprit PR above:
To Test:
dailyprompt-XXXX
tag for the current day IS NOT FOLLOWEDView all responses
on the Prompts cardRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: