Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prompts] Fix response list paging regression #19730

Merged

Conversation

thomashorta
Copy link
Contributor

@thomashorta thomashorta commented Dec 4, 2023

Fixes #19728

The correct code was already in production until the release of 23.7, when it was removed because of an old PR (created before the correct code fix was merged in the past) that was rebased and I didn't realize it reverted to the wrong behavior.

PR that introduced the regression: #18340

This PR basically reintroduces the fix made by #18276 that was reverted by the culprit PR above:


To Test:

  1. Install and log into the Jetpack app
  2. Make sure the dailyprompt-XXXX tag for the current day IS NOT FOLLOWED
  3. Go to the dashboard
  4. Tap View all responses on the Prompts card
  5. Scroll the prompt tag responses list for a while
  6. Verify pagination is working properly (posts are not shifting around, just being added at the end)
  7. Verify posts keep loading when reaching the end of the feed as long as there are posts available

Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • Update relevant unit test.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

The fixed code was removed because of an old PR that was recently rebased and I
didn't realize it reverted the proper behavior as it was originally made on top
of an older version containing this bug.

Culprit PR: #18340
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 4, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@thomashorta thomashorta changed the title [Prompts] Fix responses paging regression [Prompts] Fix response list paging regression Dec 4, 2023
@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ This PR is assigned to the milestone 23.8 ❄️. The due date for this milestone has already passed.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19730-90f8b07
Commit90f8b07
Direct Downloadjetpack-prototype-build-pr19730-90f8b07.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19730-90f8b07
Commit90f8b07
Direct Downloadwordpress-prototype-build-pr19730-90f8b07.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It's working as expected :shipit:

@thomashorta thomashorta merged commit 468f560 into release/23.8 Dec 5, 2023
20 checks passed
@thomashorta thomashorta deleted the issue/19728-prompts-view-responses-pagination branch December 5, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants