Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications redesign #1861

Merged
merged 153 commits into from
Sep 12, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
153 commits
Select commit Hold shift + click to select a range
6c21cad
Initial commit of new model testing and UI updates.
roundhill Jun 11, 2014
7b1daf1
Added support for following sites to UserNoteBlock
roundhill Jun 11, 2014
f6b9c40
Added support for showing blog preview and post detail views when cer…
roundhill Jun 11, 2014
36ce6fc
Removed image and video views from note_block_basic layout.
roundhill Jun 12, 2014
61891c2
Added support for using NoteBlockClickableSpan for the Url TextView i…
roundhill Jun 12, 2014
0a21746
Fixed wonky fragment transactions. Need to fix landscape tablet layou…
roundhill Jun 12, 2014
204b909
Removed now-unused private members.
roundhill Jun 12, 2014
db0f3b3
Tablet improvements and fixed blinking when loading detail fragment.
roundhill Jun 13, 2014
e2d5360
Code cleanup, moved media player attachment to where VideoView was be…
roundhill Jun 13, 2014
8ac0b6d
Fixed row highlight on tablets.
roundhill Jun 13, 2014
854249d
Fixed up tablet layout and rotation.
roundhill Jun 16, 2014
2d041ad
Fixed rotating to landscape on a tablet when viewing a detail view.
roundhill Jun 17, 2014
6f53a5f
Better handling of tablet rotation, just pop the entire back stack in…
roundhill Jun 17, 2014
e44afb8
Select first row when on a landscape tablet when the activity starts.
roundhill Jun 17, 2014
0012e0c
Restores selected note when rotating tablet from portrait to landscape.
roundhill Jun 17, 2014
bae5604
Explicitly tell the notes adapter whether it should highlight rows in…
roundhill Jun 17, 2014
8e7badd
Fixed automattcher check for automattcher's that are comments (in add…
roundhill Jun 18, 2014
c2b6178
Center basic note block text if it is being displayed with an image.
roundhill Jun 18, 2014
0c8a47d
Animate images after they are downloaded to catch the eye.
roundhill Jun 19, 2014
01cf0d1
Comment snippet is now displayed in the ListView.
roundhill Jun 19, 2014
f64e0da
Added custom fragment animation when navigating from list to detail v…
roundhill Jun 25, 2014
baa297f
Use `replace` instead of `add` in fragment transaction.
roundhill Jun 26, 2014
4309263
Moved header out of detaillistfragment, and created a `NotificationsD…
roundhill Jun 26, 2014
5fe68c7
Merge branch 'develop' into feature/notifications-redesign
roundhill Jun 26, 2014
6c52fff
Remove `BigBadgeFragment`
roundhill Jun 26, 2014
ca10373
Fixed a crash caused by the merge with develop.
roundhill Jun 26, 2014
29296db
Removed overshoot animation as I couldn't get it looking quite right.
roundhill Jun 26, 2014
e4e563e
Fixed a crash when `NotificationsActivity` was resumed after being ki…
roundhill Jun 27, 2014
943c107
Use standard `dimen/avatar_sz_large` for notes list avatar.
roundhill Jul 11, 2014
183cd76
* Cleaned up code in Note model.
roundhill Jul 15, 2014
915dfd4
Tighter top/bottom padding on subject header.
roundhill Jul 15, 2014
99ee3b9
`CommentDetailFragment` now loads a `NotificationDetailListFragment` …
roundhill Jul 15, 2014
5c9275e
Added touch listener to the gravatar displayed in a user note block t…
roundhill Jul 15, 2014
1b893a7
Develop merge of *DOOOM*
roundhill Jul 17, 2014
44fa269
Enabled marking a note as read again.
roundhill Jul 18, 2014
4877d55
Merge branch 'Develop' into 'notifications-redesign'
roundhill Jul 25, 2014
f63c229
Note subject ids can now be tapped.
roundhill Jul 28, 2014
640a137
Comment ids should be italic.
roundhill Jul 28, 2014
d93b254
Comment view redesign. Still a WIP
roundhill Jul 29, 2014
ecd7b3a
Comment notifications now load in the Reader.
roundhill Jul 30, 2014
840f065
Limited subject to one line.
roundhill Jul 30, 2014
52b67cb
Derp. Fixed reader comment list from not updating.
roundhill Jul 31, 2014
87d9233
Unmoderated comments now appear in reader list with special formatting.
roundhill Jul 31, 2014
c81a896
Revert "Unmoderated comments now appear in reader list with special f…
roundhill Jul 31, 2014
27a244a
Revert "Derp. Fixed reader comment list from not updating."
roundhill Jul 31, 2014
5d4d42b
Revert "Limited subject to one line."
roundhill Jul 31, 2014
b7b9e00
Revert "Comment notifications now load in the Reader."
roundhill Jul 31, 2014
058efa9
Revert "Comment view redesign. Still a WIP"
roundhill Jul 31, 2014
15e568e
Comment like support added to `CommentDetailFragment`
roundhill Aug 1, 2014
eced80b
Corrected JSON query to be a long when retrieving blogId/sideId.
roundhill Aug 3, 2014
7e148e1
Comment reply parents are now formatted differently, limited to 4 lines.
roundhill Aug 4, 2014
efc9cd2
Added new block that displays certain comments with italics and limit…
roundhill Aug 4, 2014
273de10
Restoring top padding for basic note blocks.
roundhill Aug 4, 2014
bc15b4d
Adds timestamp back to the list view.
roundhill Aug 11, 2014
97883a8
Made the note block image slightly smaller.
roundhill Aug 11, 2014
55bb291
Design updates to notifications list.
roundhill Aug 12, 2014
ba0bc91
`CommentDetailFragment` design updates:
roundhill Aug 15, 2014
4ca178b
Added approve/unapprove icons.
roundhill Aug 15, 2014
912af90
Spam button permanently demoted to overflow menu.
roundhill Aug 18, 2014
d159c6d
Use orange checkmark for approved active state instead of cancel icon.
roundhill Aug 19, 2014
99bc0da
Merge branch 'develop' into feature/notifications-redesign
roundhill Aug 20, 2014
f318416
Cleaned up some margin spacing in the footer buttons.
roundhill Aug 20, 2014
13bd5ac
Links on blocks are now a different color than the rest of the text.
roundhill Aug 21, 2014
f9c921d
Removed `NotificationsDetailFragment`
roundhill Aug 21, 2014
2634e69
Renamed classes and organized code.
roundhill Aug 21, 2014
64792b8
Removed follow button from user block.
roundhill Aug 21, 2014
85dbcf7
Redesigned user block layout
roundhill Aug 22, 2014
ef8f662
ensure `getSpannableTextFromIndices` doesn't return `null`
roundhill Aug 22, 2014
3827957
Use new array values in note20 model.
roundhill Aug 25, 2014
50266e8
Restored gray menu drawer background.
roundhill Aug 25, 2014
94064af
New blocks and design tweaks to match new design for comments.
roundhill Aug 25, 2014
2b81f55
Badge notifications display on blue bg and is centered vertically.
roundhill Aug 26, 2014
d79395a
Perform some trimming on the note subject to fix some formatting bugs.
roundhill Aug 26, 2014
0882d1a
Fixed font alignment layout bugs.
roundhill Aug 26, 2014
1bc7bfe
Renamed `NotificationUtils` to `NotificationsUtils` to match up.
roundhill Aug 26, 2014
a6b8ff9
Spacing adjustments to match 48dp rhythm.
roundhill Aug 26, 2014
be465fc
Fixed blue background from showing in header divider.
roundhill Aug 26, 2014
da140bc
Comment replies now have a special background shape drawable.
roundhill Aug 26, 2014
e340bd4
Added 'ago' text timestamp to comment view.
roundhill Aug 27, 2014
b35f83f
Set up `comment` note id type to load the reader.
roundhill Aug 27, 2014
9f46f66
Comment user block now changes bg and text color based on comment sta…
roundhill Aug 27, 2014
b91b3d3
Tweaked colors and border widths.
roundhill Aug 27, 2014
25053cc
Changed `ids` to `ranges`, yay.
roundhill Aug 27, 2014
41a4a11
Leave the detail view once a comment is marked as spam.
roundhill Aug 27, 2014
7598e80
Missed changing an `ids` reference to `ranges`.
roundhill Aug 28, 2014
4e4314f
Allow ranges with no type and a Url to be the link color.
roundhill Aug 28, 2014
fe36325
Pixel-perfect font alignment for comments layout.
roundhill Aug 28, 2014
102d667
Cleaned up `Note.java`.
roundhill Aug 28, 2014
e930bb0
Removed aggressive `JSONUtil` logging
roundhill Aug 28, 2014
e88518a
You can now select the entire note detail header row.
roundhill Aug 28, 2014
ea96bd9
Fixed the tablet landscape UI.
roundhill Aug 28, 2014
4018925
Moar tablet/fragment fixes.
roundhill Aug 28, 2014
8f03ef2
Updated time groupings to final design.
roundhill Aug 29, 2014
5c0747c
Cleaned up the comment detail fragment layout to match new design.
roundhill Aug 29, 2014
33007fa
Code cleanup.
roundhill Aug 29, 2014
17599a0
Merge branch 'develop' into feature/notifications-redesign
roundhill Aug 29, 2014
46f2835
Design updates based on feedback from designer dave.
roundhill Aug 30, 2014
37ebac7
Changed `Note.getBlogId()` to `Note.getSiteId()`
roundhill Aug 30, 2014
6dac18b
Removed cached instance variables from the Note model.
roundhill Aug 30, 2014
ba948cc
Restoring some comment like icons I accidentally deleted in 46f2835fb…
roundhill Aug 30, 2014
afff04c
Use new icons for trash and spam action buttons.
roundhill Aug 30, 2014
1fb76f7
Corrected time groupings to compare against actual day instead of hou…
roundhill Sep 1, 2014
201902f
Like button now shows on comments that the user can't moderate.
roundhill Sep 1, 2014
ee2800f
Fixed `Like` button state.
roundhill Sep 1, 2014
d31d37a
Notifications code cleanup.
roundhill Sep 1, 2014
06a5cd6
String adjustment.
roundhill Sep 1, 2014
718a7fd
Import cleanup.
roundhill Sep 1, 2014
ad64685
Merge branch 'develop' into feature/notifications-redesign
roundhill Sep 1, 2014
1774c6d
Changed NotificationsActivity to use a separate layout for tablets.
roundhill Sep 2, 2014
5fb6680
A user block row is now tappable, if it has a site Id to view.
roundhill Sep 2, 2014
977d1c3
Use `ReaderActivityLauncher` methods for launching reader activities.
roundhill Sep 2, 2014
e9ab3ac
Changed list selection restoration to use the simperium cursor to ret…
roundhill Sep 3, 2014
6daebae
Removed unneeded `launchWithNoteId()`. It is handled in `onNewIntent()`
roundhill Sep 3, 2014
422f921
Corrected timestamp grouping.
roundhill Sep 3, 2014
00c1517
Restores `CommentDetailFragment`'s reply text if it was left handing …
roundhill Sep 3, 2014
5ad118e
`user_comment` TextView should use `fill_parent`.
roundhill Sep 3, 2014
4752ee3
Cleaned up some catch blocks.
roundhill Sep 3, 2014
19d9d1d
Design update for badges, all text should be centered.
roundhill Sep 3, 2014
60defd5
Added a confirmation dialog for spamming a comment.
roundhill Sep 3, 2014
2aa9ce2
Merge branch 'develop' into feature/notifications-redesign
roundhill Sep 3, 2014
fe5a883
Fixed duplicate cache check in `TypefaceCache`.
roundhill Sep 3, 2014
91ee66e
Pass second null parameter to super for custom TextViews.
roundhill Sep 3, 2014
43076ac
Corrected hard-coded dp resource. Hat tip @nbradbury!
roundhill Sep 3, 2014
259c8c3
Fixed a bug when rotating from landscape -> portrait on a tablet.
roundhill Sep 3, 2014
016eaba
Use `match_parent` instead of deprecated `fill_parent`.
roundhill Sep 3, 2014
9374c6c
Merge branch 'release/3.2' into feature/notifications-redesign
roundhill Sep 3, 2014
f69cc64
`stat` range types will now open `StatsActivity` for the blog, if it …
roundhill Sep 4, 2014
6ba7799
Slightly different span highlight bg color.
roundhill Sep 4, 2014
7c6e61d
Variable spelling correction.
roundhill Sep 4, 2014
be6410b
Like button now animates the star when tapped.
roundhill Sep 4, 2014
f4e2791
Comment moderation improvements. Still a WiP.
roundhill Sep 5, 2014
2c0f39a
Fixed WP.com from not loading in `NotificationsWebViewActivity`.
roundhill Sep 5, 2014
1f2e468
Removed `dropDownListViewStyle` override in the Calypso Style.
roundhill Sep 5, 2014
3f4e26c
List view position is now saved/restored.
roundhill Sep 6, 2014
88368de
Comments/Notifications activities upgraded to use 'undo bar'.
roundhill Sep 9, 2014
182843a
Fixed the multi-select highlight in the comments list.
roundhill Sep 9, 2014
5639a42
Switch to approved status when liking an unapproved comment.
roundhill Sep 9, 2014
74f050f
Merge branch 'release/3.2' into feature/notifications-redesign
roundhill Sep 9, 2014
cd97394
Use `PhotonUtils.fixAvatarUrl` in blocks.
roundhill Sep 9, 2014
16e2813
Fixed editing a comment from a notification.
roundhill Sep 10, 2014
bbdaf31
Set ScrollView to `match_parent` in height so that the progress bar s…
roundhill Sep 10, 2014
84d90b7
Show image animation one time only, tweaked `pop.xml` animation.
roundhill Sep 10, 2014
bb78afe
Code inspector cleanup!
roundhill Sep 10, 2014
bf670e9
Tapping on the header in a comment reply now takes you to the comment…
roundhill Sep 11, 2014
4106f86
Longer `pop` animation duration.
roundhill Sep 11, 2014
1781036
Created constants for colors used in `NoteBlockClickableSpan` and `Us…
roundhill Sep 11, 2014
04d9453
Reverted `NotificationsWebViewActivity` to use `loadUrl()` as it was …
roundhill Sep 11, 2014
1a18fa5
Don't show keyboard when starting `CommentDetailActivity`.
roundhill Sep 11, 2014
e1a2f17
Added support for moderation actions when `CommentDetailFragment` doe…
roundhill Sep 11, 2014
4e60211
Show comment detail when tapping header from a comment like, or neste…
roundhill Sep 11, 2014
8e561c1
Corrected null check to be for `progressBar`.
roundhill Sep 12, 2014
f10b3ae
Cleaned up some of the naming around loading a remote comment from a …
roundhill Sep 12, 2014
496c2a1
`CommentDetailFragment` now manages comment reply tasks, like it did …
roundhill Sep 12, 2014
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions WordPress/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,12 @@

<!-- Comments activities -->
<activity
android:name=".ui.comments.CommentsActivity" />
android:name=".ui.comments.CommentsActivity"
android:theme="@style/CalypsoTheme" />
<activity
android:name=".ui.comments.CommentDetailActivity"
android:theme="@style/CalypsoTheme"
android:windowSoftInputMode="stateHidden" />
<activity
android:name=".ui.comments.EditCommentActivity" />

Expand Down Expand Up @@ -238,7 +243,8 @@

<!-- Notifications activities -->
<activity
android:name=".ui.notifications.NotificationsActivity"/>
android:name=".ui.notifications.NotificationsActivity"
android:theme="@style/CalypsoTheme" />

<activity
android:name=".ui.notifications.NotificationsWebViewActivity"
Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
import org.wordpress.android.analytics.AnalyticsTracker.Stat;
import org.wordpress.android.analytics.AnalyticsTrackerMixpanel;
import org.wordpress.android.ui.notifications.NotificationDismissBroadcastReceiver;
import org.wordpress.android.ui.notifications.NotificationUtils;
import org.wordpress.android.ui.notifications.NotificationsActivity;
import org.wordpress.android.ui.notifications.utils.NotificationsUtils;
import org.wordpress.android.ui.posts.PostsActivity;
import org.wordpress.android.ui.prefs.AppPrefs;
import org.wordpress.android.util.AppLog;
Expand Down Expand Up @@ -285,15 +285,15 @@ protected void onRegistered(Context context, String regId) {
SharedPreferences settings = PreferenceManager.getDefaultSharedPreferences(context);
if (!TextUtils.isEmpty(regId)) {
// Get or create UUID for WP.com notes api
String uuid = settings.getString(NotificationUtils.WPCOM_PUSH_DEVICE_UUID, null);
String uuid = settings.getString(NotificationsUtils.WPCOM_PUSH_DEVICE_UUID, null);
if (uuid == null) {
uuid = UUID.randomUUID().toString();
SharedPreferences.Editor editor = settings.edit();
editor.putString(NotificationUtils.WPCOM_PUSH_DEVICE_UUID, uuid);
editor.putString(NotificationsUtils.WPCOM_PUSH_DEVICE_UUID, uuid);
editor.commit();
}

NotificationUtils.registerDeviceForPushNotifications(context, regId);
NotificationsUtils.registerDeviceForPushNotifications(context, regId);

AnalyticsTracker.registerPushNotificationToken(regId);
}
Expand Down
10 changes: 5 additions & 5 deletions WordPress/src/main/java/org/wordpress/android/WordPress.java
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
import org.wordpress.android.networking.SelfSignedSSLCertsManager;
import org.wordpress.android.ui.ActivityId;
import org.wordpress.android.ui.accounts.SetupBlogTask.GenericSetupBlogTask;
import org.wordpress.android.ui.notifications.NotificationUtils;
import org.wordpress.android.ui.notifications.SimperiumUtils;
import org.wordpress.android.ui.notifications.utils.NotificationsUtils;
import org.wordpress.android.ui.notifications.utils.SimperiumUtils;
import org.wordpress.android.ui.prefs.AppPrefs;
import org.wordpress.android.ui.stats.service.StatsService;
import org.wordpress.android.util.AppLog;
Expand Down Expand Up @@ -318,7 +318,7 @@ public static void registerForCloudMessaging(Context context) {
if (WordPress.hasValidWPComCredentials(context)) {
if (!TextUtils.isEmpty(regId)) {
// Send the token to WP.com in case it was invalidated
NotificationUtils.registerDeviceForPushNotifications(context, regId);
NotificationsUtils.registerDeviceForPushNotifications(context, regId);
AppLog.v(T.NOTIFS, "Already registered for GCM");
}
}
Expand Down Expand Up @@ -500,7 +500,7 @@ public static void removeWpComUserRelatedData(Context context) {
// a Volley request
VolleyUtils.cancelAllRequests(requestQueue);

NotificationUtils.unregisterDevicePushNotifications(context);
NotificationsUtils.unregisterDevicePushNotifications(context);
try {
GCMRegistrar.checkDevice(context);
GCMRegistrar.unregister(context);
Expand Down Expand Up @@ -690,7 +690,7 @@ private void updatePushNotificationTokenIfNotLimited() {
AppLog.e(T.NOTIFS, "Could not ping the PNs backend, Token or gmcID not found");
} else {
// Send the token to WP.com
NotificationUtils.registerDeviceForPushNotifications(mContext, token);
NotificationsUtils.registerDeviceForPushNotifications(mContext, token);
}
} catch (Exception e) {
AppLog.e(T.NOTIFS, "Could not ping the PNs backend: " + e.getMessage());
Expand Down
Loading