-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetpack Content Migration Flow] Integrate local migration with UI #17516
Conversation
Since the number of flags has become quite large, this utility class can be useful for conditioning the migration.
Though this emission does not signal failure (i.e. it can fail silently), it can still be encapsulated within the login helper. Since the token is persisted in a private shared preference, it should be less error-prone. If it is necessary, later we can set the preference more directly with `commit` instead of `apply`.
This is useful so we don't have to wait for syncing the account data with the server to display the avatar in the welcome screen.
These are useful for wiring up the results in the migration to the UI.
This provides for a single mutable state flow to be consumed by the UI, encapsulating the possible states of the data migration.
5cde933
to
e8caa50
Compare
📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17516-03837ef.apk
|
📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17516-03837ef.apk
|
…local-migration-with-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mkevins 👍
The code changes make sense to me and the UI is cleanly integrated with the migration flow. I've tested the flow on a Pixel 5 (Android 13) and everything worked as expected 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved ✅
Fixes #17508
To test:
Enable the following flags in the
build.gradle
Generate some local-only content:
Follow the steps in #17398
Testing steps:
Uninstall the Jetpack app or log out of Jetpack and delete all data.
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.