Introduce updated locale picker #16331
Conversation
…id into feature/updated-locale-picker � Conflicts: � WordPress/src/main/java/org/wordpress/android/modules/ViewModelModule.java
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
|
@ravishanker, @develric, 👋 , I've requested you as reviewers as you'd originally reviewed the initial PR (and it seemed like it was close to being approved). Let me know if anything needs changing here or if there are perhaps other reviewers who should be added. I'd love to try to get this over the finish line. 🙇♀️ For further context, the reason I'm trying to get the improved locale picker merged is that I'd like to fix the following issue with missing language options in the site settings: #16312. That fix will involve the addition of ~100 more language options under site settings, which wouldn't work very well with the existing locale picker. |
…mobile/WordPress-Android into feature/updated-locale-picker
|
Thank you, @khaykov! 🙇♀️ @ravishanker, @develric, if you have no objections, I'll go ahead to merge this PR tomorrow. |
| } | ||
| }) | ||
|
|
||
| viewModel.hideKeyboard.observe(viewLifecycleOwner, { |
There was a problem hiding this comment.
Lambda argument can be moved outside parenthesis like so. Update all of them
viewModel.hideKeyboard.observe(viewLifecycleOwner) {
ActivityUtils.hideKeyboardForced(binding?.searchInputLayout)
}
There was a problem hiding this comment.
Done in 158d11e, thank you for reviewing! 🙌
This notation was mistakenly removed following previous updates from trunks.
Note, this PR was originally created by @khaykov at #14836. As the
developbranch was deleted, it was not possible to reopen the original PR, which is why a new PR has been generated based ontrunk.This PR updates the look of the app's locale picker, following the same design as the site timezone picker. It can be searched by both label and localized label.
To test:
- You can filter locales by both their label and localized label (eg. typing "Dani" and "Dans" should produce list with "Danish/Dansk" locale)
- Tapping on locale changes app language.
- Current app locale is displayed a the top of the list. Tapping on it closes the list.
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.