Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Weekly Roundup toggle to Notification settings #15325

Merged
merged 8 commits into from
Sep 15, 2021

Conversation

renanferrari
Copy link
Member

This PR adds an option in the Notification settings screen to disable Weekly Roundup notifications for a certain site.

This also adds an option on the Debug Settings screen to force show the Weekly Roundup notification, making it possible to test this without making any changes to the code.

To test

  1. Login with an account that has at least one site that had more than 5 views in the past week.
  2. On the Main screen, Tap the Me button.
  3. On the Me screen, go to App Settings > Debug settings.
  4. On the Debug Settings screen, scroll down to the Tools section and tap "Force show Weekly Roundup notification".
  5. Wait for the Weekly Roundup notifications to show up (this might take a while).
  6. Go back to the Main screen and tap the Notifications tab.
  7. Tap the gear icon on the top right corner of the screen.
  8. Under "Your sites", tap on one of the sites that had previously shown a Weekly Roundup notification.
  9. Under "Notification Types", tap "App notifications".
  10. Disable the Weekly Roundup option and tap "Ok".
  11. Go back to the Debug settings screen and force show the Weekly Roundup notifications again.
  12. Wait for the Weekly Roundup notifications to show up again.
  13. Verify that the disabled site doesn't show a Weekly Roundup notification anymore.

Regression Notes

  1. Potential unintended areas of impact
    Other notification settings.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing and existing unit tests.

  3. What automated tests I added (or what prevented me from doing so)
    Unit tests.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Great job.

@ravishanker ravishanker merged commit 33ea1ff into release/18.2 Sep 15, 2021
@ravishanker ravishanker deleted the feature/weekly-roundup-toggle branch September 15, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants