Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Remove image count from gallery processor #15196

Merged

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Aug 16, 2021

Description

This PR removes the imageCount attribute from the gallery block upload completion processor (and the test content). Originally, this attribute was used to return early from the regular processor, and signal a subsequent recursion to handle inner blocks. It turns out that the absense of the ids attribute is sufficient to accomplish the same. This PR removes the cruft (since this attribute has now been removed from the block schema), and updates the test content to reflect the latest format.

To test:
Run the unit tests for the upload completion processors.

Manual test:
Test the upload flow in this test with the refactored version of the gallery.

Regression Notes

  1. Potential unintended areas of impact
    Uplodate completion processors

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Updated unit tests for the change in content

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@mkevins mkevins added this to the 18.1 milestone Aug 16, 2021
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mkevins 👍
The code changes LGTM and the app works as expected 🎉

@mkevins mkevins merged commit 744050e into develop Aug 18, 2021
@mkevins mkevins deleted the rnmobile/fix/remove-image-count-from-gallery-processor branch August 18, 2021 04:07
@mkevins
Copy link
Contributor Author

mkevins commented Aug 18, 2021

Thanks Antonis for testing and reviewing. 😃

@AliSoftware AliSoftware modified the milestones: 18.1, 18.2 Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants