[Gutenberg] Remove image count from gallery processor #15196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
imageCount
attribute from the gallery block upload completion processor (and the test content). Originally, this attribute was used to return early from the regular processor, and signal a subsequent recursion to handle inner blocks. It turns out that the absense of theids
attribute is sufficient to accomplish the same. This PR removes the cruft (since this attribute has now been removed from the block schema), and updates the test content to reflect the latest format.To test:
Run the unit tests for the upload completion processors.
Manual test:
Test the upload flow in this test with the refactored version of the gallery.
Regression Notes
Potential unintended areas of impact
Uplodate completion processors
What I did to test those areas of impact (or what existing automated tests I relied on)
Updated unit tests for the change in content
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.