-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetpack] Update playstore metadata #15005
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,7 +66,13 @@ ALL_LOCALES = [ | |
{ glotpress: "kmr", android: "kmr", promo_config: false}, | ||
].freeze | ||
|
||
RELEASE_NOTES_LOCALES = ALL_LOCALES.reject { |h| h[:google_play].nil? }.map { |h| [h[:glotpress], h[:google_play]] } | ||
RELEASE_NOTES_LOCALES = ALL_LOCALES | ||
.reject { |h| h[:google_play].nil? } | ||
.map { |h| [h[:glotpress], h[:google_play]] } | ||
JP_RELEASE_NOTES_LOCALES = ALL_LOCALES | ||
.reject { |h| h[:google_play].nil? } | ||
.select { |h| %w[ar de-DE es-ES fr-FR iw-IL id it-IT ja-JP ko-KR nl-NL pt-BR ru-RU sv-SE tr-TR zh-CN zh-TW].include?(h[:google_play]) } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it make sense to add |
||
.map { |h| [h[:glotpress], h[:google_play]] } | ||
Comment on lines
+69
to
+75
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that Jetpack's GlotPress uses a different set of locales than WordPress (especially, no 🔜 Side note: I already have plans/ideas to make that mess with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice! You can ignore my comment above. I am just keeping it for full disclosure. |
||
|
||
APP_SPECIFIC_VALUES = { | ||
wordpress: { | ||
|
@@ -658,8 +664,13 @@ REPOSITORY_NAME="WordPress-Android" | |
##################################################################################### | ||
desc "Downloads translated metadata from GlotPress" | ||
lane :download_metadata_strings do |options| | ||
app = options[:app] || 'wordpress' | ||
paths = APP_SPECIFIC_VALUES[app.to_sym] | ||
download_wordpress_metadata_strings(options) unless options[:app] != 'wordpress' | ||
download_jetpack_metadata_strings(options) unless options[:app] != 'jetpack' | ||
end | ||
|
||
desc "Downloads WordPress's translated metadata from GlotPress" | ||
lane :download_wordpress_metadata_strings do |options| | ||
app_values = APP_SPECIFIC_VALUES[:wordpress] | ||
values = options[:version].split('.') | ||
files = { | ||
"release_note_#{values[0]}#{values[1]}" => {desc: "changelogs/#{options[:build_number]}.txt", max_size: 500, alternate_key:"release_note_short_#{values[0]}#{values[1]}"}, | ||
|
@@ -668,24 +679,55 @@ REPOSITORY_NAME="WordPress-Android" | |
play_store_app_title: {desc:"title.txt", max_size: 50} | ||
} | ||
|
||
delete_old_changelogs(build: options[:build_number]) | ||
download_path = File.join(Dir.pwd, paths[:metadata_dir], 'android') | ||
delete_old_changelogs(app: 'wordpress', build: options[:build_number]) | ||
download_path = File.join(Dir.pwd, app_values[:metadata_dir], 'android') | ||
# The case for the source locale (en-US) is pulled in a hacky way, by having an {en-gb => en-US} mapping as part of the RELEASE_NOTES_LOCALES, | ||
# which is then treated in a special way by gp_downloadmetadata by specifying a `source_locale: 'en-US'` to process it differently from the rest. | ||
Comment on lines
+684
to
+685
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a hack that took me a while to understand/undercover, as I first I didn't understand from the action's API (and its description and succinct params doc) why we were using 🔜 I'm hoping to update the release-toolkit to improve that logic at some point in the future – to make this not needed to add a "twisted" entry in the list of locales (with en-gb=>en-US mapping that stands out without explanation), and even not requiring us to have |
||
gp_downloadmetadata( | ||
project_url: paths[:gp_url], | ||
project_url: app_values[:gp_url], | ||
target_files: files, | ||
locales: RELEASE_NOTES_LOCALES, # Currently the same for WP and JP | ||
locales: RELEASE_NOTES_LOCALES, | ||
source_locale: "en-US", | ||
download_path: download_path | ||
) | ||
|
||
if app == 'jetpack' | ||
# For WordPress, the en-US release notes come from what's downloaeded from GlotPress' en-gb locale. | ||
# But for Jetpack, we don't have en-gb in its GP release note project, so copy from source instead as a fallback | ||
FileUtils.cp(File.join(Dir.pwd, '..', 'WordPress', 'metadata', 'jetpack_release_notes.txt'), File.join(download_path, 'en-US', 'changelogs', "#{options[:build_number]}.txt")) | ||
end | ||
|
||
android_create_xml_release_notes(download_path: download_path, build_number: "#{options[:build_number]}", locales: RELEASE_NOTES_LOCALES) | ||
sh("git add #{download_path} && git commit -m \"Update #{app} metadata translations for #{options[:version]}\" && git push origin HEAD") | ||
sh("git add #{download_path} && git commit -m \"Update WordPress metadata translations for #{options[:version]}\" && git push origin HEAD") | ||
end | ||
|
||
desc "Downloads Jetpack's translated metadata from GlotPress" | ||
lane :download_jetpack_metadata_strings do |options| | ||
UI.message("Hey") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey 👋 |
||
app_values = APP_SPECIFIC_VALUES[:jetpack] | ||
values = options[:version].split('.') | ||
files = { | ||
"release_note_#{values[0]}#{values[1]}" => {desc: "changelogs/#{options[:build_number]}.txt", max_size: 500, alternate_key:"release_note_short_#{values[0]}#{values[1]}"}, | ||
'short-description': {desc:"short_description.txt", max_size: 80}, | ||
'app-store-description': {desc:"full_description.txt", max_size: 0}, | ||
'app-store-name': {desc:"title.txt", max_size: 50} | ||
} | ||
|
||
delete_old_changelogs(app: 'jetpack', build: options[:build_number]) | ||
download_path = File.join(Dir.pwd, app_values[:metadata_dir], 'android') | ||
gp_downloadmetadata( | ||
project_url: app_values[:gp_url], | ||
target_files: files, | ||
locales: JP_RELEASE_NOTES_LOCALES, | ||
download_path: download_path | ||
) | ||
|
||
# For WordPress, the en-US release notes come from using the source keys (instead of translations) downloaded from GlotPress' en-gb locale (which is unused otherwise). | ||
# But for Jetpack, we don't have an unused locale like en-gb in the GP release notes project, so copy from source instead as a fallback | ||
metadata_source_dir = File.join(Dir.pwd, '..', 'WordPress', 'jetpack_metadata') | ||
FileUtils.cp(File.join(metadata_source_dir, 'release_notes.txt'), File.join(download_path, 'en-US', 'changelogs', "#{options[:build_number]}.txt")) | ||
FileUtils.cp( | ||
['title.txt', 'short_description.txt', 'full_description.txt'].map { |f| File.join(metadata_source_dir, f) }, | ||
File.join(download_path, 'en-US') | ||
) | ||
|
||
locales_including_enUS = [['en-gb', 'en-US']] + JP_RELEASE_NOTES_LOCALES # first item (GlotPress locale) unused for this action; second param = google_play locale | ||
android_create_xml_release_notes(download_path: download_path, build_number: "#{options[:build_number]}", locales: locales_including_enUS) | ||
sh("git add #{download_path} && git commit -m \"Update Jetpack metadata translations for #{options[:version]}\" && git push origin HEAD") | ||
end | ||
|
||
######################################################################## | ||
|
@@ -958,11 +1000,11 @@ REPOSITORY_NAME="WordPress-Android" | |
##################################################################################### | ||
# Private lanes | ||
##################################################################################### | ||
private_lane :delete_old_changelogs do | options | | ||
Dir.glob("./metadata/android/*/").each do | folder | | ||
Dir["#{folder}changelogs/*"].each do | file | | ||
File.delete(file) if Integer(File.basename(file, ".*")) < Integer(options[:build]) rescue puts "Cannot delete file #{file}" | ||
end | ||
private_lane :delete_old_changelogs do |options| | ||
app = options[:app] || 'wordpress' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I personally much prefer transparency because I find that minor verbosity helps with reading the code. (not this code, but the one that'll call this lane) Can we force the caller to specify the app for that benefit? Since it's ruby, we don't get the static typing, but still, at least it's not going to do something unexpected when I forget to specify a parameter. What do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah actually I think fastlane has a build-in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this is a private lane, I think we can just drop the default value and call it done. If I am understanding the setup correctly, we should always have access to the |
||
app_values = APP_SPECIFIC_VALUES[app.to_sym] | ||
Dir.glob(File.join(app_values[:metadata_dir], 'android', '*', 'changelogs', '*')).each do |file| | ||
File.delete(file) if Integer(File.basename(file, ".*")) < Integer(options[:build]) rescue puts "Cannot delete file #{file}" | ||
end | ||
end | ||
|
||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
احصل على أدوات الأمان والأداء الفعالة في متناول يديك بفضل Jetpack الخاص بنظام تشغيل Android. | ||
|
||
استعد موقعك من أي مكان إذا حدث خطأ ما. افحص بحثًا عن تهديدات وقم بإصلاحها بنقرة واحدة. راقب نشاط الموقع لمعرفة من غيَّر ماذا ومتى. راجع إحصاءاتك لمعرفة البلدان الجديدة التي يأتي منها الزائرون اليوم. | ||
|
||
يدعم التطبيق كذلك ميزات ووردبريس التي تتوقعها. يمكنك إنشاء مسودة من قصيدة شعرية وأنت جالس على الأريكة. التقط صورة وانشرها في فترة استراحتك لتناول الغداء. رد على تعليقاتك الأخيرة. | ||
|
||
يدعم Jetpack الخاص بنظام تشغيل Android مواقع ووردبريس التي تتضمن Jetpack تم تمكينه وحسابًا متصلاً بووردبريس.كوم. | ||
|
||
View the Privacy Notice for California Users at https://automattic.com/privacy/#california-consumer-privacy-act-ccpa. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
احصل على أدوات الأمان والأداء الفعالة في متناول يديك. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Jetpack: أمان ووردبريس وسرعته |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
Jetpack für Android bietet dir leistungsstarke Sicherheits- und Performance-Tools für deine Hosentasche. | ||
|
||
Stelle deine Website wieder her, wenn ein Problem auftritt. Prüfe auf Bedrohungen und entferne sie mit einmaligem Tippen. Bleibe auf dem Laufenden über die Website-Aktivität und sieh dir an, wer wann was geändert hat. Rufe deine Statistiken dazu ab, aus welchen neuen Ländern die heutigen Besucher kommen. | ||
|
||
Die App unterstützt darüber hinaus die von dir erwarteten WordPress-Funktionen. Entwirf ein spontanes Haiku auf der Couch. Schieße in deiner Mittagspause ein Foto und lade es gleich hoch. Antworte auf die neuesten Kommentare. | ||
|
||
Jetpack für Android unterstützt WordPress-Websites mit aktiviertem Jetpack und einem mit WordPress.com verbundenen Konto. | ||
|
||
View the Privacy Notice for California Users at https://automattic.com/privacy/#california-consumer-privacy-act-ccpa. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Leistungsstarke Sicherheits- und Performance-Tools für deine Hosentasche. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Jetpack: WP-Sicherheit und -Geschwindigkeit |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
Get powerful security and performance tools in your pocket with Jetpack for Android. | ||
|
||
Restore your site from anywhere if something goes wrong. Scan for threats and resolve them with a tap. Keep tabs on site activity to see who changed what and when. Check your stats to see what new countries today’s visitors are coming from. | ||
|
||
The app also supports WordPress features that you expect. Draft a spontaneous haiku from the couch. Snap and post a photo on your lunch break. Respond to your latest comments. | ||
|
||
Jetpack for Android supports WordPress sites with Jetpack enabled and an account connected to WordPress.com. | ||
|
||
View the Privacy Notice for California Users at https://automattic.com/privacy/#california-consumer-privacy-act-ccpa. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Get powerful security and performance tools in your pocket. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Jetpack: WP Security & Speed |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
Consigue potentes herramientas de seguridad y rendimiento con Jetpack para Android. | ||
|
||
Restaura tu sitio desde cualquier lugar si se produce algún error. Identifica amenazas y resuélvelas con un toque. Haz un seguimiento de la actividad del sitio para comprobar quién cambio qué y cuándo lo hizo. Consulta las estadísticas para ver de qué nuevos países provienen los visitantes de hoy. | ||
|
||
La aplicación también es compatible con las funciones de WordPress que esperas. Escribe un haiku espontáneo desde el sofá. Haz una foto y publícala en el descanso para comer. Responde a los últimos comentarios. | ||
|
||
Jetpack para Android es compatible con los sitios de WordPress que tengan Jetpack activado y una cuenta conectada a WordPress.com. | ||
|
||
View the Privacy Notice for California Users at https://automattic.com/privacy/#california-consumer-privacy-act-ccpa. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Consigue potentes herramientas de seguridad y rendimiento. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Jetpack: seguridad y rapidez de WP |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
Bénéficiez d’outils de sécurité et de performance puissants avec Jetpack pour Android. | ||
|
||
Rétablissez votre site où que vous soyez en cas de problème. Détectez les menaces et supprimez-les d’un simple appui. Gardez un œil sur l’activité du site pour voir qui a modifié quoi et quand. Consultez vos statistiques pour voir de quels nouveaux pays sont originaires les visiteurs du jour. | ||
|
||
L’application prend également en charge les fonctionnalités WordPress que vous attendez. Rédigez un haïku spontané depuis votre canapé. Prenez une photo et publiez-la pendant votre pause déjeuner. Répondez à vos derniers commentaires. | ||
|
||
Jetpack pour Android prend en charge les sites WordPress utilisant Jetpack et un compte connecté à WordPress.com. | ||
|
||
View the Privacy Notice for California Users at https://automattic.com/privacy/#california-consumer-privacy-act-ccpa. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Bénéficiez d’outils de sécurité et de performance puissants. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Jetpack : WP Security & Speed |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
Dapatkan alat penunjang keamanan dan performa yang andal dengan Jetpack untuk Android. | ||
|
||
Pulihkan situs dari mana saja jika terjadi kesalahan. Pindai ancaman dan atasi dengan sekali ketuk. Pantau aktivitas situs untuk melihat perubahan yang dilakukan, siapa yang melakukannya, dan kapan. Periksa statistik untuk melihat asal negara pengunjung hari ini. | ||
|
||
Aplikasi ini juga mendukung fitur WordPress yang Anda harapkan. Rangkai haiku secara spontan dari sofa Anda. Bidik dan poskan foto saat istirahat makan siang. Tanggapi komentar terbaru. | ||
|
||
Jetpack untuk Android mendukung situs WordPress dengan Jetpack aktif dan akun yang terhubung ke WordPress.com. | ||
|
||
View the Privacy Notice for California Users at https://automattic.com/privacy/#california-consumer-privacy-act-ccpa. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Dapatkan alat penunjang keamanan dan performa yang andal dalam genggaman Anda. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Jetpack: WP Security & Speed |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
Porta gli strumenti per le prestazioni e la sicurezza in tasca con Jetpack per Android. | ||
|
||
Ripristina il tuo sito da qualsiasi luogo se qualcosa va storto. Scansiona le minacce e risolvile con un tocco. Tieni sotto controllo l'attività del sito per vedere chi ha modificato qualcosa e quando. Controlla le statistiche per scoprire da quali nuovi Paesi provengono i visitatori di oggi. | ||
|
||
L'app supporta anche le funzionalità di WordPress su cui fai affidamento. Crea una bozza di un haiku spontaneo dal divano. Scatta e pubblica una foto della tua pausa pranzo. Rispondi agli ultimi commenti. | ||
|
||
Jetpack per Android supporta siti WordPress con Jetpack abilitato e un account connesso a WordPress.com. | ||
|
||
View the Privacy Notice for California Users at https://automattic.com/privacy/#california-consumer-privacy-act-ccpa. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Porta gli strumenti per le prestazioni e la sicurezza in tasca. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Jetpack: sicurezza e velocità di WP |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
להשתמש בכלים עוצמתיים לאבטחה ולביצועים ישירות מהטלפון עם Jetpack ל-Android. | ||
|
||
לשחזר את האתר מכל מקום אם משהו משתבש. לסרוק את האתר לאיתור איומים ולפתור אותם בהקשה אחת. לעקוב אחר הפעילות באתר כדי לראות מי שינה מה ומתי. לבדוק את הנתונים הסטטיסטיים שלך כדי לראות מאיזו מדינה נכנסו היום הבקרים באתר שלך. | ||
|
||
האפליקציה תומכת גם באפשרויות המוכרות של WordPress. לשבת על הספה ולכתוב חמשיר. לצלם תמונה בהפסקת הצהריים ולפרסם אותה. לענות על התגובות האחרונות שקיבלת. | ||
|
||
האפליקציה של Jetpack ל-Android תומכת באתרי WordPress.com שבהם מופעל השירות של Jetpack ושאליהם מחובר חשבון WordPress.com. | ||
|
||
View the Privacy Notice for California Users at https://automattic.com/privacy/#california-consumer-privacy-act-ccpa. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
להשתמש בכלים עוצמתיים לאבטחה ולביצועים ישירות מהטלפון. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Jetpack: המהירות והאבטחה של WP |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also update this name to
WP_RELEASE_NOTES_LOCALES
?