Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/revert paging3 migration #14949

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Conversation

khaykov
Copy link
Member

@khaykov khaykov commented Jun 25, 2021

Fixes #14860

Migration to Paging 3 is causing some issues with Post List. We need a bit more for a partial or full migration to Paging 3.

This PR removes the Paging 3 dependency and comments out the code that is using it, since it's behind the feature flag.

To test:

  • Make sure that the app builds without any issue.
  • Go to the post list and scroll down quickly
  • Notice that post loading is performed correctly, the list remains visible and nothing crashes.

Regression Notes

  1. Potential unintended areas of impact
    We are removing the offending library so should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 25, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@khaykov khaykov marked this pull request as ready for review June 25, 2021 17:26
@khaykov khaykov requested a review from develric June 25, 2021 17:26
Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @khaykov , was able to replicate the crash in a test site with more than 100 test draft post. Also confirm I didn't get the crash with the apk from this PR. Did some smoke testing and didn't encounter issues. We should be safe to go 👍 !

@develric develric merged commit 460b0dd into develop Jun 25, 2021
@develric develric deleted the issue/revert-paging3-migration branch June 25, 2021 20:55
@develric develric mentioned this pull request Jul 1, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post list fails to refresh or crashes the app when you scroll quickly
2 participants