Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix RN 0.64 upgrade insert link crash #14802

Closed
wants to merge 6 commits into from

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Jun 8, 2021

Fixes #

gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#3597

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 8, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is missing at least one label.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 9, 2021

You can test the changes on this Pull Request by downloading the APK here.

@hypest
Copy link
Contributor Author

hypest commented Jun 9, 2021

Tried the installable build built off f8c8083 and it doesn't crash for me when trying to add a link inside a paragraph by tapping on the link toolbar button! 🎉

Base automatically changed from gutenberg/upgrade-RN-0-64 to develop June 16, 2021 19:40
@hypest
Copy link
Contributor Author

hypest commented Jun 17, 2021

Fix has been included in the main RN 0.64 upgrade PRs already and those got merged already so, closing this 🎉.

@hypest hypest closed this Jun 17, 2021
@hypest hypest deleted the gutenberg/upgrade-RN-0-64-hypest branch December 20, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant