Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React Native to 0.64 #14702

Merged
merged 46 commits into from
Jun 16, 2021
Merged

Upgrade React Native to 0.64 #14702

merged 46 commits into from
Jun 16, 2021

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented May 24, 2021

Upgrading react-native to version 0.64.0

To test: Follow instructions on gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#3430

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

marecar3 and others added 30 commits January 31, 2020 17:25
update gb-mobile ref
# Conflicts:
#	libs/gutenberg-mobile
# Conflicts:
#	libs/gutenberg-mobile
# Conflicts:
#	libs/gutenberg-mobile
# Conflicts:
#	libs/gutenberg-mobile
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 24, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@cameronvoell
Copy link
Contributor Author

cameronvoell commented May 24, 2021

Ci error here will be fixed when this PR is merged #14623 and we rebase our gutenberg/upgrade-RN-0-64 branch with develop

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 1, 2021

You can test the changes on this Pull Request by downloading the APK here.

@ceyhun ceyhun marked this pull request as ready for review June 2, 2021 15:37
@ceyhun ceyhun added this to the 17.6 milestone Jun 2, 2021
@AliSoftware
Copy link
Contributor

Moving this PR to next milestone, since 17.6 goes into code freeze today.

@AliSoftware AliSoftware modified the milestones: 17.6, 17.7 Jun 14, 2021
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The writing flow tests worked for me (via a sibling PR). As usual, we'll wait for thumbs-ups in gutenberg-mobile and Gutenberg to do the domino merge.

@ceyhun ceyhun enabled auto-merge June 16, 2021 19:36
@ceyhun ceyhun merged commit 238a442 into develop Jun 16, 2021
@ceyhun ceyhun deleted the gutenberg/upgrade-RN-0-64 branch June 16, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants