-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Audio block capability now enables/disables media upload's media sources #14680
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
This PR will be updated once wordpress-mobile/gutenberg-mobile#3548 is merged in so a final |
@jd-alexander Heads up that the PR is already merged |
Lint failures are unrelated to the changes I made. Not sure what is causing them. I will check that out tomorrow. |
This happened to me too on a different PR and after restarting the job it worked 🤷♂️ . I'll restart it for you if you don't mind just in case it works. |
Perhaps needs update from develop @jd-alexander ? |
Indeed! I am going to give that a go shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
Approved via WordPress/gutenberg#31966 (review).
The installable build is failing because the tab |
Heads up that this PR can't be merged at this stage because the Gutenberg Mobile reference contains changes from this other PR that neither can't be merged due to the lack of the changes from this one 🙃 . I pinged @SiobhyB, as the author of that PR, and we decided to merge these changes there, here is the merge commit. Once that PR gets merged, this will be automatically closed. |
Fixes wordpress-mobile/gutenberg-mobile#3523
WordPress iOS
wordpress-mobile/WordPress-iOS#16533Gutenberg Mobile
wordpress-mobile/gutenberg-mobile#3523Gutenberg
WordPress/gutenberg#31966Description
This PR checks to see if the user's site is on a free, paid or self hosted plan and as such, the relevant media upload options are shown.
Testing
WP.com sites
Note:
Support for Audio block audio uploads, and access to the media library is restricted to sites that are on a paid plan.
Free Plan
Insert from URL
option is available as users aren't able to upload audio on free plans.Paid plan
Self hosted sites
Regression Notes
The blocks Cover, File, Gallery, Video, Media & Text all utilise the
media-upload
component that was modified. Verify that these blocks function as expected and all the relevant options are still shown for them in both paid and free plans.What I did to test those areas of impact (or what existing automated tests I relied on)
There are existing tests that are doing uploads via the WP media library and the file system so if there was an issue with the implementation those tests would fail.
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.