Prevent Homepage from being deleted or moved to a draft

[chipsnyder]

Fixes: #13908

To test:

📓 Make sure your site is set to have a Static Homepage

Attempt to delete Homepage

1. Navigate to the Page List
2. Select the ... on the Homepage
3. Expect to NOT see the Move to Trash option
   📓 If the Homepage has been moved out of the Published filter then the Move to Trash option will still be there. The site is already broken so no reason to restrict it.

Screenshot

Attempt to move Homepage to Draft - Page List

📓 This doesn't apply if you've trashed your Homepage.

1. Navigate to the Page List
2. Select the ... on the Homepage
3. Expect to NOT see the Move to Draft

Screenshot

Attempt to move Homepage to Draft - Page Settings

1. Navigate to the Page List
2. Select Homepage to open the Editor
3. Select the ... in the top right-hand corner
4. Select Page Settings
5. Select Status
6. Expect to only have the Publish option and Private Option.
   📓 On iOS Private is handled by a different menu.

Screenshot

Attempt to delete Page

1. Navigate to the Page List
2. Select the ... on a page that is not the Homepage
3. Expect to see the Move to Trash option
4. Select Move to Trash
5. Expect for the page to be deleted

Attempt to move Page to Draft - Page List

1. Navigate to the Page List
2. Select the ... on a page that is not the Homepage
3. Select Move to Draft
4. Expect to see the page be moved to a draft.

Attempt to move Page to Draft - Page Settings

1. Navigate to the Page List
2. Select a page (not Homepage) to open the Editor
3. Select the ... in the top right-hand corner
4. Select Page Settings
5. Select Status
6. Change the status
7. Expect to see the screen to dismiss and the page will modify to the new status.

PR submission checklist:

• I have considered adding unit tests where possible.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[peril-wordpress-mobile]

You can test the changes on this Pull Request by downloading the APK here.

[antonis]

Nice work @chipsnyder 👍
Tested the App on an Pixel 2 XL with Android 11 and behaves as expected.
The code changes are consistent and LGTM 🎉

Regarding the failing checks:

1. The CreatePageListItemActionsUseCaseTest tests should be ok by removing the MOVE_TO_DRAFT, MOVE_TO_TRASH values from the expected actions. It would be nice if we added a couple more tests to verify the new if branch in the CreatePageListItemActionsUseCase.

2. The lint check failure has to do with the introduction of Detekt and a fix is already available in develop

[chipsnyder]

Regarding the failing checks:

1. The CreatePageListItemActionsUseCaseTest tests should be ok by removing the MOVE_TO_DRAFT, MOVE_TO_TRASH values from the expected actions. It would be nice if we added a couple more tests to verify the new if branch in the CreatePageListItemActionsUseCase.

2. The lint check failure has to do with the introduction of Detekt and a fix is already available in develop

Thanks for the help @antonis! I totally forgot to come back and validate these checks before I logged off for the day. I updated the tests that check the available settings for Homepages and it looks like a test already existed for pages that aren't homepages.

[chipsnyder]

The installable build is still failing but that should be resolved by #14082 once that's available

[antonis]

Thanks for the help @antonis! I totally forgot to come back and validate these checks before I logged off for the day. I updated the tests that check the available settings for Homepages and it looks like a test already existed for pages that aren't homepages.

Thank you for the changes @chipsnyder 👍
LGTM 🎉