Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test/lint annotations on pr #14056

Closed
wants to merge 4 commits into from

Conversation

loremattei
Copy link
Contributor

Fixes #

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@@ -708,8 +708,7 @@ public void onTokenValid(String token, String title, String message) {
@Override
public void onTokenInvalid() {
// Show a toast if the user took too long to open the notification
ToastUtils.showToast(WPMainActivity.this, R.string.push_auth_expired,
ToastUtils.Duration.LONG);
ToastUtils.showToast(WPMainActivity.this, R.string.push_auth_expired, ToastUtils.Duration.LONG);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter: Checkstyle
Rule: com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck
Severity: ERROR
File: /home/circleci/project/WordPress/src/main/java/org/wordpress/android/ui/main/WPMainActivity.java L711
Line is longer than 120 characters (found 124).

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@loremattei loremattei changed the title Test/lint annotations on pr [DO NOT MERGE] Test/lint annotations on pr Feb 12, 2021
@loremattei loremattei mentioned this pull request Feb 12, 2021
3 tasks
@loremattei loremattei closed this Feb 15, 2021
@loremattei loremattei deleted the test/lint-annotations-on-pr branch February 15, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants