Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dot Blog domains for all URL searches #13917

Merged
merged 5 commits into from
Feb 1, 2021
Merged

Enable dot Blog domains for all URL searches #13917

merged 5 commits into from
Feb 1, 2021

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Jan 29, 2021 •
edited
Loading

Fixes #13653

To test:

  1. Go to My Site > Switch Site > "+" > Create WordPress.com site
  2. Tap "SKIP" or select any design.
  3. Type a keyword to search for a site address
  4. Expect to see .wordpress.com and .blog subdomains populated.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added this to the 16.7 milestone Jan 29, 2021
@chipsnyder chipsnyder requested review from antonis and mkevins January 29, 2021 18:32
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 29, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

chipsnyder
chipsnyder commented Jan 29, 2021
View reviewed changes
.../src/main/java/org/wordpress/android/ui/sitecreation/domains/SiteCreationDomainsViewModel.kt
@@ -140,7 +142,16 @@ class SiteCreationDomainsViewModel @Inject constructor(
updateUiStateToContent(query, Loading(Ready(emptyList()), false))
fetchDomainsJob = launch {
delay(THROTTLE_DELAY)
val onSuggestedDomains = fetchDomainsUseCase.fetchDomains(query.value, segmentId)
val onSuggestedDomains: OnSuggestedDomains
if (homePagePickerFeatureConfig.isEnabled()) {
Copy link
Contributor Author

@chipsnyder chipsnyder Jan 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this check just to support the segments if we decide to A/B test it still

@chipsnyder chipsnyder marked this pull request as ready for review January 29, 2021 18:44
@chipsnyder chipsnyder linked an issue Jan 29, 2021 that may be closed by this pull request
Unable to select a .blog subdomain #13653
Closed
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 29, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

mkevins
mkevins approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and this is working as described. I tested via Pixel 3a (physical device).

@chipsnyder chipsnyder merged commit 92fc430 into develop Feb 1, 2021
@chipsnyder chipsnyder deleted the issue/13653-domains branch February 1, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

@antonis antonis Awaiting requested review from antonis

Assignees
No one assigned
Labels
Site Creation [Type] Bug
Projects
None yet
Milestone
16.7
Development

Successfully merging this pull request may close these issues.

Unable to select a .blog subdomain
2 participants
@chipsnyder @mkevins