Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unread post counter feature. #13732

Closed
wants to merge 4 commits into from

Conversation

khaykov
Copy link
Member

@khaykov khaykov commented Jan 8, 2021

This PR enables an unread post count feature.

To test:

  • Install the app using vanilla flavor.
  • Make sure you haven't manually overridden the flag.
  • Confirm that the unread post count is visible in Reader's Following site filter.

Image from Gyazo

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 8, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 8, 2021

You can test the changes on this Pull Request by downloading the APK here.

@khaykov khaykov marked this pull request as ready for review January 8, 2021 19:48
@khaykov khaykov requested a review from develric January 8, 2021 19:48
@khaykov khaykov modified the milestones: 16.5, 16.6 Jan 8, 2021
Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @khaykov 😄 . Looks good and works as expected 👍 . Only left a minor comment, let me know wdyt 🙇

@@ -3,7 +3,7 @@
[***] Block Editor: Cross-post suggestions are now available by typing the + character (or long-pressing the toolbar button labelled with an @-symbol) in a post on a P2 site [https://github.com/wordpress-mobile/WordPress-Android/pull/13184]
[***] Activity Log: Adds support for Date Range and Activity Type filters. [https://github.com/wordpress-mobile/WordPress-Android/issues/13268]
* [**] Page List: Adds duplicate page functionality [https://github.com/wordpress-mobile/WordPress-Android/pull/13607]

* [**] Reader: introduced an Unread Post counter in the Site Filter bottom sheet. [https://github.com/wordpress-mobile/WordPress-Android/pull/13732]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we should link this PR that has more details in the description? wdyt?

…g' of github.com:wordpress-mobile/WordPress-Android into feature/remove-unread-count-feature-flag
@khaykov khaykov modified the milestones: 16.6, 16.7 Jan 22, 2021
@khaykov
Copy link
Member Author

khaykov commented Jan 23, 2021

Will reopen later with modifications.

@khaykov khaykov closed this Jan 23, 2021
@khaykov khaykov deleted the feature/remove-unread-count-feature-flag branch March 29, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants