Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/uppercase thousands suffix #13723

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Conversation

khaykov
Copy link
Member

@khaykov khaykov commented Jan 7, 2021

In this PR we are uppercasing an English suffix for 1000 (k > K) to align with iOS, as mentioned here. That string is translatable, so other locales could use an appropriate suffix.

The suffix will be changed in the stats and unread posts counter.

Image from Gyazo

In addition, I removed the unneeded has() check, that was mentioned here.

To test:

  • You can check the new uppercase suffix in Stats (for values > 9999) or in unread posts count (if you have enough posts).

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@khaykov khaykov added this to the 16.5 milestone Jan 7, 2021
@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@khaykov khaykov requested a review from develric January 8, 2021 00:05
Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @khaykov , works as described 👍 . :shipit:

@develric develric merged commit fe56754 into develop Jan 8, 2021
@develric develric deleted the issue/uppercase-thousands-suffix branch January 8, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants