-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote field to ActivityLogFiltersFeatureConfig #13722
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @malinajirka! Everything looks and works great! 🌟
Just few things:
I've introduce a remote feature flag and I enabled it by default.
It wasn't enabled by default for me. Can you recheck or I might be missing something.
Also can we remove this highlighted message for a paid plan site?
Thanks so much for the review @ashiagr!
Could you please double check two things
I tested this yesterday on the CI build which works as expected. When I read your comment I tested it locally and it didn't work. However, I realized I re-cloned the repo 2 days ago and I forgot to setup google-services.json. When I downloaded it, it started working even on the local builds.
I checked and the site is on a free plan. I'll double check the conditions on the web and create a ticket if it should be hidden when the user has purchased a product. |
I can confirm that Calypso displays the "Since you're on a free plan, you'll..." message only on sites which haven't purchased any product and are on a free plan. I'll create a separate PR. Update: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting the issue 🙏.
Also I can see activity filters from the CI build. So we're good here.
Let's 🚢 it! Great job!
Fixes #13268
This PR enables remote feature flag for the Activity Type Filters and updates release notes.
Note:
I've introduce a remote feature flag and I enabled it by default.
To test:
PR submission checklist:
RELEASE-NOTES.txt
if necessary.