Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote field to ActivityLogFiltersFeatureConfig #13722

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Jan 7, 2021

Fixes #13268

This PR enables remote feature flag for the Activity Type Filters and updates release notes.

Note:
I've introduce a remote feature flag and I enabled it by default.

To test:

  1. Clear app data to make sure the manual feature flag configuration gets removed
  2. Do NOT manually turn on the feature flag
  3. Verify the Activity Log filters are working even though the build time feature flag in build.gradle is set to false (make sure the site has paid plan or backup product)
  • All the code related to the feature has been tested. However, it'd be good if you could spent a few minutes testing the feature in its final stage. Thanks!

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

Base automatically changed from issue/13268-activity-log-filters-visibility to develop January 7, 2021 16:22
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @malinajirka! Everything looks and works great! 🌟

Just few things:

I've introduce a remote feature flag and I enabled it by default.

It wasn't enabled by default for me. Can you recheck or I might be missing something.

Also can we remove this highlighted message for a paid plan site?

Screenshot 2021-01-08 at 1 33 39 PM

@malinajirka
Copy link
Contributor Author

malinajirka commented Jan 8, 2021

Thanks so much for the review @ashiagr!

It wasn't enabled by default for me. Can you recheck or I might be missing something.

Could you please double check two things

  1. Are you able to log into the app using Google SSO?
  2. Are you using a site with a paid plan or back up feature?

I tested this yesterday on the CI build which works as expected. When I read your comment I tested it locally and it didn't work. However, I realized I re-cloned the repo 2 days ago and I forgot to setup google-services.json. When I downloaded it, it started working even on the local builds.

Also can we remove this highlighted message for a paid plan site?

I checked and the site is on a free plan. I'll double check the conditions on the web and create a ticket if it should be hidden when the user has purchased a product.

Screenshot 2021-01-08 at 10 43 34

@malinajirka
Copy link
Contributor Author

malinajirka commented Jan 8, 2021

I can confirm that Calypso displays the "Since you're on a free plan, you'll..." message only on sites which haven't purchased any product and are on a free plan. I'll create a separate PR.

Update:
I've submitted an issue. I think it's better to wait until we implement "fetch jetpack capabilities" on MySite fragment and use cached value in the Activity Log.

@ashiagr ashiagr self-requested a review January 8, 2021 10:42
Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the issue 🙏.
Also I can see activity filters from the CI build. So we're good here.

Let's 🚢 it! Great job!

@ashiagr ashiagr merged commit cccdb2a into develop Jan 8, 2021
@ashiagr ashiagr deleted the issue/13268-enable-remote-feature-flag branch January 8, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Section: Activity Log
2 participants